-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Versions in the new moveit metapkg and its member packages #9
Comments
Hi, @v4hn asked me to comment regarding the downgrade of ikfast. One solution would be to add an epoch to the package, but I haven't seen an option in bloom to do this. (@wjwwood can you comment?). The other option is obviously to go with 3.x ;). |
Note: Rational on moveit_ikfast - version 1 was for arm_navigation, version 2 was some messy version that supported arm_nav and moveit, and version 3 was the rewrite that I did that renamed it and turned it into moveit_ikfast as we know it today. I was worried about its version number and one thought was to deprecate that package and move it into If there are difficulties downgrading the version of ikfast, I think we should post-pone releasing a new version of the ikfast plugin into bloom (by adding a CATKIN_IGNORE to it?) because:
|
To answer @130s proposal, I like Option A sticking to the closest version possible. I assume you mean, however, that it would be version |
You can modify the Debian files how ever you like by patching them in bloom. So adding an epoch to the version would be possible. As you describe it, the package seems to be infrequently updated and so, could just leave it as a separate repository? You definitely should not consider downgrading the version number of it, or any package for that matter. That's a really bad solution in my opinion. You could also eol the package and make a new package to replace it or merge it with another replayed package. |
Thanks for the opinions. I guess we're making a consensus so far as follows. If there's no objections (maybe for half a day? Too hasty?), I'll go ahead opening PRs to implement these.
*1. There's no 0.9.x so far in MoveIt! world but I guess what Dave suggests makes sense since other 2 distros are aligned at 0.x.3. |
Lets certainly give the ikfast topic more input from others, in an different issue on the main repo. +1 to moving forward with releasing everything else with those version numbers. |
Proposed versions are accepted. Now, release. |
Oh wait, ikfast. I'll open PRs. |
Continuing from #3 (comment)
@davetcoleman @v4hn @mikeferguson @IanTheEngineer
I'd want agreement for the version for the new
moveit
meta package and its member packages, in order to make releases per each distro. I propose Option-A and B so give opinion for either options, or another option is welcomed.Since Jade release needs to happen soon moveit/moveit#22 I appreciate your quick input (sorry, this proposal should've been made way earlier..).
To release packages under a meta-package umbrella, they all need to be the same version AFAIK. Currently there's a version deviation per packages (full set can be seen here) as the table below.
My proposal for the new
moveit
package:moveit_msgs
just for updating their versions.moveit_msgs
's version too.I prefer Option-B but I don't find any strong reason not to keep the versions so Option-A is possible.
Caviat of my proposal above:
moveit_ikfast
needs to be downgraded (unless we decide to use the numbers larger than 3.X)The text was updated successfully, but these errors were encountered: