Upgrade to new Minitest constant + new dev env + 3.3 bugfix #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, change bin/setup to account for changes in the gemspec
|
Fixes #323 |
davetron5000
commented
Jul 16, 2024
|
|
||
| I am responsive on issues, so reach out there if you have a question. | ||
|
|
||
| ## How to Do Development |
There was a problem hiding this comment.
Clearer docs on how to do local dev for GLI
davetron5000
commented
Jul 16, 2024
| @@ -92,16 +92,20 @@ Get a more detailed walkthrough on the {main site}[http://davetron5000.github.io | |||
|
|
|||
| == Supported Platforms | |||
|
|
|||
| See `.circleci/config.yml` for the supported rubies, but general we're running tests on the all MRI rubies receiving support, which tends to be the most recent four versions. | |||
| See `dx/docker-compose.env` and the variable `RUBY_VERSIONS` for the versions that are supported. This should generally track with the supported version of Ruby from Ruby's maintainers. | |||
There was a problem hiding this comment.
Ref to which versions are supported
davetron5000
commented
Jul 16, 2024
| @@ -80,6 +80,9 @@ Rake::TestTask.new("test:unit") do |t| | |||
| ENV["RUBYOPT"].split(/\s/).each do |opt| | |||
| t.ruby_opts << opt | |||
| end | |||
| if t.ruby_opts.none? { |x| x =~ /^\-W/ } | |||
There was a problem hiding this comment.
Stop showing warnings - some of the code in the tests does stuff you wouldn't want in prod code but I don't feel like fixing it and don't think they are issues. RUBYOPT can be set explicitly to avoid this behavior
davetron5000
commented
Jul 16, 2024
| @@ -26,5 +26,5 @@ spec = Gem::Specification.new do |s| | |||
| s.add_development_dependency("rdoc") | |||
| s.add_development_dependency("rainbow", "~> 1.1", "~> 1.1.1") | |||
| s.add_development_dependency("sdoc") | |||
| s.add_development_dependency("minitest") | |||
| s.add_development_dependency("minitest", "~> 5") | |||
There was a problem hiding this comment.
Clarify the version of minitest
davetron5000
commented
Jul 16, 2024
| @@ -121,7 +121,7 @@ def self.mk_rakefile(root_dir,dry_run,project_name,create_test_dir) | |||
| rd.title = 'Your application title' | |||
| end | |||
|
|
|||
| spec = eval(File.read('#{project_name}.gemspec')) | |||
| spec = Gem::Specification.load("#{project_name}.gemspec") | |||
There was a problem hiding this comment.
Bug in Ruby 3.3 - not sure why eval(File.read(...)) didn't work but Gem::Specification.load seems to be the more correct way to do this.
|
Released as 2.21.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A few:
MiniTesttoMinitestlike 10 years ago, but compatibilty was removed somewhat recently. Discovered by @rsanheim inCan't build/run tests - due to old ruby version / minitest changes? #323
nonsense, which I absolutely despise.
Solution
CONTRIBUTING.mdfor docs).MiniTesttoMinitestto avoid having to deal with compatibility. That change is 10 years old, so even super old unsupportedRubies should still work.
Gem::Specification.loadto load the spec into theRakefile.