-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update favicons. closes #57 #59
Conversation
@davewasmer @Exelord ~1 year later, this PR is still pretty much up to date and it would mean a big win for everybody. It's also a very easy win. :) What can I do to help getting this merged? |
Hi Miguel, Somehow I missed that notification, sorry :/ We need to ensure the 6.0 does not bring any breaking change in the config as well. The CI is not setup so that might be also a next step before. |
Once tests will be green, I'm happy to merge :) |
@Exelord looks like I need your approval for the github workflow to run. |
I went ahead and removed the |
@Exelord increased timeouts. GH actions are probably slower? 🤷♂️ |
@Exelord Yay. Tests are 💚 . |
Thanks a lot! <3 |
@Exelord my pleasure. |
This PR updates the favicons package.
There are a number of reasons for this update, but the main ones I found were:
npm install
s and increases compatibility (phantomjs builds aren't available for all architectures)The second bullet point was actually what made me update the "mocks" for the data we expect. Basically, by default, the package produces more favicons and more html.
It would probably be safer to major bump this package after merging this, since favicons was also major bumped.