Append to the host file on Win32 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zetlen I saw that you started merging some PRs back. I have a few changes from a private fork that I would like to bring over. This is the first of them |
zetlen
reviewed
Oct 29, 2019
There was a problem hiding this comment.
Thanks, @dlannoye. This is a very important change. I know that the >> append redirect works in CMD.EXE as well as POSIX shells, but can you confirm that it works if the user has forced their standard shell to be PowerShell? (If this command bypasses the user's default shell, that's okay too.
|
I tested running the |
|
Thanks @dlannoye ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently devcert will create a new host file on windows rather then appending to the existing host file.