Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #43

Merged
Merged

Conversation

rhyolight
Copy link
Collaborator

Will be working on handling HTTP errors and leftover half-downloaded packages in upcoming PR.

  • 80 char line limit
  • using string formatting instead of concats
  • raising fatal exceptions

- 80 char line limit
- using string formatting instead of concats
- raising fatal exceptions
@rhyolight
Copy link
Collaborator Author

@Davidragazzi Don't merge this yet, I'm getting test failures...

∙ ./run_tests.sh -u
======================================================================== test session starts =========================================================================
platform darwin -- Python 2.7.6 -- pytest-2.4.2 -- /usr/bin/python
cachedir: /Users/mtaylor/nta/nupic/.cache
plugins: cov, xdist, cache
collecting 3 items / 1 errors
=============================================================================== ERRORS ===============================================================================
____________________________________________ ERROR collecting tests/unit/nupic/algorithms/anomaly_likelihood_jeff_test.py ____________________________________________
tests/unit/nupic/algorithms/anomaly_likelihood_jeff_test.py:36: in <module>
>   from nupic.algorithms import anomaly_likelihood as an
nupic/algorithms/__init__.py:28: in <module>
>   from nupic.bindings.math import NearestNeighbor
nupic/bindings/math.py:28: in <module>
>       _math = swig_import_helper()
nupic/bindings/math.py:20: in swig_import_helper
>           import _math
E           ImportError: No module named _math
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
====================================================================== 1 error in 0.25 seconds =======================================================================

david-ragazzi pushed a commit that referenced this pull request Dec 5, 2014
@david-ragazzi david-ragazzi merged commit 852e380 into david-ragazzi:build_extensions Dec 5, 2014
@david-ragazzi
Copy link
Owner

Oh sorry!!

@rhyolight
Copy link
Collaborator Author

No, is okay. The failures I'm seeing are also on your original PR. So no problem.

@david-ragazzi
Copy link
Owner

I'm on mobile right now! If you can wait until go home..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants