Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for dotty compiler #393

Closed
danlehmann opened this issue Mar 20, 2020 · 9 comments
Closed

Support for dotty compiler #393

danlehmann opened this issue Mar 20, 2020 · 9 comments

Comments

@danlehmann
Copy link

As far as I can tell, the scala-maven-plugin doesn't support the dotty compiler (Scala 3.0) yet. This would be a useful feature to have to allow people to get their projects compatible early.

@slandelle
Copy link
Collaborator

Contributions welcome :)

@slandelle
Copy link
Collaborator

FWIW, I've upgraded zinc to 1.4.2, maybe this would help with Scala 3 support.

@andreacastello
Copy link

andreacastello commented Mar 4, 2021

Hello. Using the last version (4.4.1) with a Scala 3.0.0-RC1 project it causes this error:
Could not find artifact org.scala-lang:scala-library:jar:3.0.0-RC1

This artifact name is built at runtime with a logic that is not valid anymore for Scala 3 because the naming convention has changed (see: https://mvnrepository.com/artifact/org.scala-lang/scala3-library_3.0.0-RC1) and the class ScalaMojoSupport uses a constant token value for the artifact name.

@aesteve
Copy link

aesteve commented Mar 10, 2021

Faced the same issue. Relevant snippet:

ScalaMojoSupport.SCALA_COMPILER_ARTIFACTID,

Is there a property or something we can override to test it any further? Thank you.

@slandelle
Copy link
Collaborator

Again: people, please be nice open source citizens: contribute!

If nobody contributes, I will definitely tackle it myself someday, meaning probably 1 year from now.

@andreacastello
Copy link

Again: people, please be nice open source citizens: contribute!

If nobody contributes, I will definitely tackle it myself someday, meaning probably 1 year from now.

You are right. I'm sorry if my comment has been seen as a call to action: it wasn't. It was just a hint of where one of the "migration issues" may be. I have taken a look at the code: in the beginning I thought I could provide a quick fix for this, but now I think that making it work on dotty will require a much bigger effort than just differentiating naming tokens for "scala" and "scala3".

I'll try to experiment a bit (but, same as you, I have not much time to dedicate to it) and come back if I have something decent to share.

@aesteve
Copy link

aesteve commented Mar 10, 2021 via email

@martin-g
Copy link

This issue could be closed in favour of this PR - #447

@davidB
Copy link
Owner

davidB commented May 8, 2021

scala 3.0 support updated and release since 4.5.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants