Skip to content
This repository has been archived by the owner on Mar 23, 2022. It is now read-only.

upgrading to latest yuicompressor 2.4.7 #45

Closed
wants to merge 5 commits into from
Closed

upgrading to latest yuicompressor 2.4.7 #45

wants to merge 5 commits into from

Conversation

pkuczynski
Copy link
Contributor

hey,

I uploaded latest yuicompressor to maven central, and I upgraded the reference in pom.xml. It would be good if you could accept this pull request and release newer version of your plugin, as my project is depending on this :)

List of changes in latest yuicompressor 2.4.7:

https://github.com/yui/yuicompressor/blob/master/doc/CHANGELOG

  • Handle data urls without blowing up Java memory (regex)
  • Updated docs to reflect Java >= 1.5 required for CssCompressor
  • Fixed issue where we were breaking #AABBCC id selectors, with the
    #AABBCC -> #ABC color compression.

@newcron
Copy link

newcron commented Jul 4, 2012

also got one recommondation: the plugin can simply be made maven 3 threasafe (as it is built now, it's perfectly thread safe anyways.):

diff --git a/src/main/java/net_alchim31_maven_yuicompressor/JSLintMojo.java b/src/main/java/net_alchim31_maven_yuicompressor/JSLintMojo.java
index 64b1c9c..fba7619 100644
--- a/src/main/java/net_alchim31_maven_yuicompressor/JSLintMojo.java
+++ b/src/main/java/net_alchim31_maven_yuicompressor/JSLintMojo.java
@@ -3,12 +3,12 @@ package net_alchim31_maven_yuicompressor;

/**

  • Check JS files with jslint.

    • *
  • @goal jslint

  • @phase process-resources

  • @author David Bernard

  • @created 2007-08-29

    • * @threadsafe
      */
      // @SuppressWarnings("unchecked")
      public class JSLintMojo extends MojoSupport {
      diff --git a/src/main/java/net_alchim31_maven_yuicompressor/YuiCompressorMojo.java b/src/main/java/net_alchim31_maven_yuicompressor/YuiCompressorMojo.java
      index 157d83f..ced5374 100644
      --- a/src/main/java/net_alchim31_maven_yuicompressor/YuiCompressorMojo.java
      +++ b/src/main/java/net_alchim31_maven_yuicompressor/YuiCompressorMojo.java
      @@ -17,12 +17,12 @@ import com.yahoo.platform.yui.compressor.JavaScriptCompressor;

    /**

  • Apply compression on JS and CSS (using YUI Compressor).

    • *
  • @goal compress

  • @phase process-resources

  • @author David Bernard

  • @created 2007-08-28

@pkuczynski
Copy link
Contributor Author

added README as per issue #44
upgraded YUIC readme

@pkuczynski pkuczynski closed this Jul 4, 2012
@pkuczynski pkuczynski reopened this Jul 4, 2012
@pkuczynski
Copy link
Contributor Author

closing this pull request, as I messed up two changes and I am not sure how to fix it now. instead created a new pull request isolating those changes:

#47

@pkuczynski pkuczynski closed this Jul 4, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants