Make ansi colors compile time feature #33
Comments
|
That seems like a candidate for a cargo feature! I'll try to get to this tomorrow. |
bors bot
added a commit
to rust-lang/rust-analyzer
that referenced
this issue
Sep 6, 2021
10165: update to tracing-tree 0.1.10, which does not pull in syn r=matklad a=davidbarsky I've updated tracing-tree to 0.1.10, which does not pull in syn and proc-macro2 (thanks for [the PR](davidbarsky/tracing-tree#32), `@matklad!).` It took a little bit more work than I expected to land davidbarsky/tracing-tree#33, but I should get that done this week. However, I didn't want to keep y'all waiting, so here's _some_ of the changes that should hopefully improve your compile times. Co-authored-by: David Barsky <me@davidbarsky.com>
|
Bit of a late update on this: I gave this a spin, but separating all the ansi-formatting functionality to exist behind a feature flag is kinda annoying, and at the time, I didn't really have a good idea how to handle it. I do now (based off a pattern I saw Eliza do in tracing-subscriber), but I think it won't make it into today's release. I'm sorry about that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've noticed that we always configure tracing tree with
with_ansi(false)in rust-analyzer, so I think we can shave a couple of dependencies off here!The text was updated successfully, but these errors were encountered: