Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put fields on their own lines #62

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

oli-obk
Copy link
Collaborator

@oli-obk oli-obk commented May 23, 2023

I'm opening this to discuss how it looks and whether we want something like this.

I'd prefer not to make it configurable, but just turn it on by default.

I'll clean up the code after we have a rendering that everyone is happy with, as currently the code has lots of magic numbers and of copy paste.

terminal example:

image

@davidbarsky
Copy link
Owner

It took me a second to adjust to what's happening here, but... yeah, I think we should go for it. I assume this is more useful for rustc?

I'd prefer not to make it configurable, but just turn it on by default.

That's certainly fair, but I think we'll need to make this a breaking change because it feels meaningfully different from the previous format. That okay?

On an aside, I wonder if it would make sense (or even, if it would be possible!) to make the field formatter implement FormatFields, but that's not a blocker at the moment and can be added if/when people complain or ask for a toggle. At the very least, it'd avoid needing wrapping a bunch of magic numbers in conditionals, branching more than it already does.

@oli-obk
Copy link
Collaborator Author

oli-obk commented May 25, 2023

There is some concern about the verbosity of this, so I'm going to create some rustc examples and will check what rustc folk think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants