Not receiving recommendations #7

bhardin · 2012-02-13T22:38:41Z

Whenever I call, current_user.recommendations, I always receive a blank list.

davidcelis · 2012-02-13T22:41:15Z

Can you verify that your current_user has liked or disliked at least one thing? If current_user hasn't rated anything, they'll get no recommendations. Likewise, if there are no other users in the system (or nobody has rated anything yet), nobody will have recommendations.

bhardin · 2012-02-13T22:45:02Z

Yes, there are two users on the system. Both of which have likes (current_user.liked) and dislikes (current_user.dislikes).

I am running on heroku, and I am curious about the command

QUEUE=recommendable rake environment resque:work

How can I verify that heroku is spinning up recommendable?

davidcelis · 2012-02-13T22:51:42Z

Heroku uses Redis To Go. Unless you set up your Redis instance as per their instructions, there's essentially no Redis connection: http://blog.redistogo.com/2010/07/26/resque-with-redis-to-go/

bhardin · 2012-02-13T22:54:58Z

I've setup RedisToGo and have it configured. I didn't know how to check the status of recommendable to see if there is anything in the queue it is trying to consume.

davidcelis · 2012-02-13T22:57:13Z

Could you gist your recommendable initializer?

bhardin · 2012-02-13T22:59:31Z

https://gist.github.com/1821282

The REDIS_TOGO Env variable is setup on heroku using:

heroku config:add REDISTOGO_URL='URL'

with the URL being what I get from the redistogo details.

davidcelis · 2012-02-13T23:10:55Z

What is the result of

$ heroku console Recommendable.redis.inspect
$ heroku console Resque.inspect

bhardin · 2012-02-13T23:19:55Z

$ heroku console Recommendable.redis.inspect
"#<Redis client v2.2.2 connected to redis://chubb.redistogo.com:9156/0 (Redis v2.4.6)>"

$ heroku console Resque.inspect
"Resque Client connected to redis://chubb.redistogo.com:9156/0"

davidcelis · 2012-02-13T23:24:05Z

Check the queue size:

$ heroku console
>> Resque.size(:recommendable)

bhardin · 2012-02-13T23:27:17Z

$ heroku console
Ruby console for myapp.heroku.com
>> Resque.size(:recommendable)
=> 7

Looks like they are queued, but not being consumed.

davidcelis · 2012-02-13T23:29:53Z

Hot. My guess is it may have something to do with Heroku's naming of their rake tasks. The link I pasted above had this code block:

require 'resque/tasks'

task "resque:setup" => :environment do
  ENV['QUEUE'] = '*'
end

desc "Alias for resque:work (To run workers on Heroku)"
task "jobs:work" => "resque:work"

It looks like you have to do that alias. This block should go in lib/tasks/resque.rake

bhardin · 2012-02-13T23:38:00Z

Edited lib/tasks/resque.rake with that code block. But doesn't looks like it is working.

$ heroku console Resque.size :recommendable
7

bhardin · 2012-02-13T23:40:58Z

So out of curiousity I attempted to run

$ heroku rake resque:work QUEUE=*

which is in the same tutorial, but higher up. When executing to check on my queue, I am now down to 5. However, that command is obviously not returning and isn't a long term solution. Let me see if it completes and returns.

davidcelis · 2012-02-13T23:46:07Z

Is your Procfile configured correctly to automatically call this command upon boot? The following line should be in there:

worker: QUEUE=recommendable [bundle exec] rake resque:work

(bundle exec may or may not be needed depending on your configuration)

bhardin · 2012-02-13T23:51:20Z

I'm on the bamboo stack, not the cedar stack. Looks like I probably need to roll over. So I will go ahead and update. Let you know what happens after.

bhardin · 2012-02-14T01:13:16Z

I have rolled everything over to the Cedar stack. Still having the same issue. It looks like the queue is getting filled, but nothing is grabbing them.

I have attempted to modify my procfile from both:

worker: QUEUE=recommendable bundle exec rake resque:work

and

worker: QUEUE=recommendable rake resque:work

EDIT: Heroku definitely sees the procfile and worker... Console says the following:

-----> Discovering process types
       Procfile declares types      -> worker
       Default types for Ruby/Rails -> console, rake, web
-----> Compiled slug size is 26.9MB
-----> Launching... done, v18

davidcelis · 2012-02-14T01:35:39Z

what about rake environment resque:work?

bhardin · 2012-02-14T01:39:17Z

Upon running heroku run rake environment resque:work it emptied the queue. Can I put that command into my Procfile?

davidcelis · 2012-02-14T01:40:16Z

Emptied the queue? Like, your queue is just fuggin' gone (I'm so sorry), or the jobs got processed?

bhardin · 2012-02-14T01:42:28Z

Before executing rake enviornement reqsque:work, The Resque.size :recommendable returned 2. After issuing heroku run rake environment reque:work, the same command returned 0.

> Resque.size :recommendable
=> 0

Jobs, look processed... But it still doesn't look like I have recommendations.

davidcelis · 2012-02-14T01:49:25Z

Assuming your model is User, and the current_user has an ID of one, can you tell me what the following returns:

$ heroku console
>> Recommendable.redis.zcard "User:1:similarities"

bhardin · 2012-02-14T01:52:19Z

irb(main):015:0> Recommendable.redis.zcard "User:1:similarities"
=> 2

davidcelis · 2012-02-14T01:58:46Z

Recommendable.redis.zrangebyscore("User:1:similarities", -1, 1).map do |user|
  Recommendable.redis.zscore "User:1:similarities", user
end

Also, what version of Recommendable are you using?

bhardin · 2012-02-14T02:00:25Z

Recommendable.redis.zrangebyscore("User:1:similarities", -1, 1).map do |user|
irb(main):038:1*   Recommendable.redis.zscore "User:1:similarities", user
irb(main):039:1> end
=> ["0", "0"]

version 0.1.4

davidcelis · 2012-02-14T02:03:44Z

Looks like the similarity values are, indeed, not being calculated correctly. I'll look into this.

bhardin · 2012-02-14T02:06:13Z

Word. Thanks.

davidcelis · 2012-02-14T02:10:13Z

However, the recommendations themselves are still generating locally for me, so it's strange that you're getting an empty array.

davidcelis · 2012-02-14T02:17:01Z

Wow. Well, the similarity bug is extremely obvious now that I see it. Still unsure of your empty recommendations array, though. Let me patch this up and we'll see if that, for some reason, fixes that for you.

davidcelis · 2012-02-14T03:29:04Z

Update to 0.1.5 and let me know if your problem persists.

Please, please, please read the CHANGELOG, though. There's a migration you'll need to run.

Also, keep in mind that Recommendable isn't going to work well with the Nano (smallest) Redis To Go instance. You'll need, at the least, the 20 MB Mini instance. Nano is not persistent.

bhardin · 2012-02-14T17:54:48Z

Did Recommendable work with Nano before version 0.1.5?

Kelend · 2012-03-19T21:39:26Z

irb(main):037:0> User.find(1).recommendations User Load (2.3ms) SELECT "users".* FROM "users" WHERE "users"."id" = $1 LIMIT 1 [["id", 1]] (1.1ms) SELECT COUNT(*) FROM "recommendable_likes" WHERE "recommendable_likes"."user_id" = 1 (1.1ms) SELECT COUNT(*) FROM "recommendable_dislikes" WHERE "recommendable_dislikes"."user_id" = 1 => []

davidcelis · 2012-03-19T21:59:09Z

I don't suppose you can run those COUNT(*) selects manually from a DB console on heroku?

blackgold9 · 2012-03-19T22:14:49Z

You sure can
result = ActiveRecord::Base.connection.select_all( “select satemetn here″ )

On Mon, Mar 19, 2012 at 2:59 PM, David Celis <
reply@reply.github.com

wrote:

I don't suppose you can run those COUNT(*) selects manually from a DB
console on heroku?

Reply to this email directly or view it on GitHub:
#7 (comment)

Kelend · 2012-03-20T14:21:20Z

(131.1ms) SELECT COUNT(*) FROM "recommendable_likes" WHERE "recommendable_likes"."user_id" = 1 => [{"count"=>"16"}]
(18.9ms) SELECT COUNT(*) FROM "recommendable_dislikes" WHERE "recommendable_dislikes"."user_id" = 1 => [{"count"=>"0"}]

blackgold9 · 2012-03-20T14:29:40Z

that looks good...
Is your redis plan the permanent one? Can you generate recs locally?

Kelend · 2012-03-24T16:54:31Z

Sorry for the delay in responding, got called into another project. Permanent redis plan, and recommendations are generating fine locally.

davidcelis · 2012-03-24T22:43:22Z

@Kelend, are you using PostgreSQL locally as well, or just on Heroku?

Kelend · 2012-03-26T13:30:26Z

@davidcelis locally is sqlite, mysql works fine too, I've been having issues getting postgreSQL set up on my local environment

davidcelis · 2012-03-26T16:15:32Z

Interesting. I'm going to go ahead and set up a new app using PostgreSQL as the database and see what happens. It could very well be some sort of incompatibility between the queries I've written and postgres; this would explain the Heroku problems. I'll let you know how that goes.

bhardin · 2012-04-10T20:41:11Z

Sorry for not responding sooner. First time I have been able to work back on this project. After setting up redis and a redis front end, I see the same error as @Kelend

uninitialized constant Restaurant::
/Users/bhardin/.rvm/gems/ruby-1.9.3-p0/gems/activerecord-3.2.0/lib/active_record/inheritance.rb:119:in `compute_type'
/Users/bhardin/.rvm/gems/ruby-1.9.3-p0/gems/activerecord-3.2.0/lib/active_record/reflection.rb:172:in `klass'
/Users/bhardin/.rvm/gems/ruby-1.9.3-p0/gems/activerecord-3.2.0/lib/active_record/associations/association.rb:117:in `klass'
/Users/bhardin/.rvm/gems/ruby-1.9.3-p0/gems/activerecord-3.2.0/lib/active_record/associations/association.rb:165:in `find_target?'
/Users/bhardin/.rvm/gems/ruby-1.9.3-p0/gems/activerecord-3.2.0/lib/active_record/associations/collection_association.rb:332:in `load_target'
/Users/bhardin/.rvm/gems/ruby-1.9.3-p0/gems/activerecord-3.2.0/lib/active_record/associations/collection_proxy.rb:44:in `load_target'
/Users/bhardin/.rvm/gems/ruby-1.9.3-p0/gems/activerecord-3.2.0/lib/active_record/associations/collection_proxy.rb:88:in `method_missing'
/Users/bhardin/.rvm/gems/ruby-1.9.3-p0/bundler/gems/recommendable-5dd278a40ab8/lib/recommendable/acts_as_recommendable.rb:113:in `create_liked_by_set'
/Users/bhardin/.rvm/gems/ruby-1.9.3-p0/bundler/gems/recommendable-5dd278a40ab8/lib/recommendable/acts_as_recommendable.rb:68:in `create_recommendable_sets'
/Users/bhardin/.rvm/gems/ruby-1.9.3-p0/bundler/gems/recommendable-5dd278a40ab8/lib/recommendable/acts_as_recommended_to.rb:634:in `predict'
/Users/bhardin/.rvm/gems/ruby-1.9.3-p0/bundler/gems/recommendable-5dd278a40ab8/lib/recommendable/acts_as_recommended_to.rb:618:in `block in update_recommendations_for'
/Users/bhardin/.rvm/gems/ruby-1.9.3-p0/gems/activerecord-3.2.0/lib/active_record/relation/batches.rb:21:in `block (2 levels) in find_each'
/Users/bhardin/.rvm/gems/ruby-1.9.3-p0/gems/activerecord-3.2.0/lib/active_record/relation/batches.rb:21:in `each'
/Users/bhardin/.rvm/gems/ruby-1.9.3-p0/gems/activerecord-3.2.0/lib/active_record/relation/batches.rb:21:in `block in find_each'
/Users/bhardin/.rvm/gems/ruby-1.9.3-p0/gems/activerecord-3.2.0/lib/active_record/relation/batches.rb:72:in `find_in_batches'
/Users/bhardin/.rvm/gems/ruby-1.9.3-p0/gems/activerecord-3.2.0/lib/active_record/relation/batches.rb:20:in `find_each'
/Users/bhardin/.rvm/gems/ruby-1.9.3-p0/gems/activerecord-3.2.0/lib/active_record/querying.rb:8:in `find_each'
/Users/bhardin/.rvm/gems/ruby-1.9.3-p0/bundler/gems/recommendable-5dd278a40ab8/lib/recommendable/acts_as_recommended_to.rb:616:in `update_recommendations_for'
/Users/bhardin/.rvm/gems/ruby-1.9.3-p0/bundler/gems/recommendable-5dd278a40ab8/lib/recommendable/acts_as_recommended_to.rb:607:in `block in update_recommendations'
/Users/bhardin/.rvm/gems/ruby-1.9.3-p0/bundler/gems/recommendable-5dd278a40ab8/lib/recommendable/acts_as_recommended_to.rb:607:in `each'
/Users/bhardin/.rvm/gems/ruby-1.9.3-p0/bundler/gems/recommendable-5dd278a40ab8/lib/recommendable/acts_as_recommended_to.rb:607:in `update_recommendations'
/Users/bhardin/.rvm/gems/ruby-1.9.3-p0/bundler/gems/recommendable-5dd278a40ab8/app/workers/recommendable/recommendation_refresher.rb:9:in `perform'

Obviously mine is on restaurants. Any fix for this? This is running locally on sqlite3

bhardin · 2012-04-10T20:44:26Z

note: When I issue the command, User.first.send :update_recommendations in console, the recommendations are created.

davidcelis · 2012-04-10T23:59:01Z

No fix for this yet because I have no idea why the error comes up. It happens for me only through Resque now, and anything in the console works. I'm stumped. I've verified that my resque worker is loading the environment correctly, so it shouldn't be getting uninitialized constants.

Kelend · 2012-04-11T01:10:58Z

Its working locally for me with the mysql2 adapter, broke using sqlite3 & pg with the same uninitialized constant error

bhardin · 2012-04-11T01:14:01Z

@davidcelis Are you using mysql locally? If so, if you change to sqlite what happens?

davidcelis · 2012-04-11T02:35:38Z

Oh shit. I was also switching between PSQL and SQLite. I'll try MySQL later tonight.

Kelend · 2012-04-11T15:15:24Z

Solved the uninitialized constant for me by modifying acts_as_recommendable.rbhas_many :liked_by, :through => :likes, :source => :user, :foreign_key => :user_id, :class_name => Recommendable.user_class.to_s has_many :disliked_by, :through => :dislikes, :source => :user, :foreign_key => :user_id, :class_name => Recommendable.user_class.to_s

I can get this to process update_recommendations on sqlite3, mysql, and postgres(on heroku)

I'm still having an issue with getting it to process in the background through Resque, but I think thats a seperate issue (my jobs aren't getting persisted into Redis)

davidcelis · 2012-04-11T16:40:05Z

@Kelend: ❤️

Would you mind opening a separate issue for that if you think it's related to Recommendable? You've seemed to solve this, and your current issue doesn't sound related to the UninitializedConstant.

Pushing up a fix to this horrible, horrible error now.

bhardin · 2012-04-11T18:20:08Z

Are you going to bundle this into 0.1.7 and push? Want to check out this awesomeness.

davidcelis · 2012-04-11T18:57:11Z

It's a shitty enough bug that I could and probably should. I was hoping to switch the app over to using Sidekiq instead of Resque, however, so if you'd give me a bit of time to do that first, you can instead point your Gemfile to the git repo instead of then.

The change to using Sidekiq has been several weeks coming, as Resque is barely maintained anymore.

davidcelis · 2012-04-11T19:33:07Z

@bhardin Done. Make sure to check the changelog and edit your initializer as needed. Resque is gone, and Sidekiq is here to stay.

bhardin · 2012-04-11T20:06:49Z

So, it is now only using Sidekiq and Resque no longer? The initalizer needs to change. Correct?

I saw from your previous message that it was going to take a while to change over to Sidekiq. Is this no longer the case? Can you give an example of what the initializer needs to look now?

bhardin · 2012-04-11T20:11:47Z

I was able to handle the initializer scripts for the app to kick off. I am now having a challenge running: bundle exec sidekiq -q recommendable

It looks like it is trying to startup a local redis server instead of using the server I specified.

2012-04-11T20:07:41Z 48401 TID-zrrt3o INFO: Booting sidekiq 1.0.0 with Redis at localhost:6379
2012-04-11T20:07:41Z 48401 TID-zrrt3o INFO: Running in ruby 1.9.3p0 (2011-10-30 revision 33570) [x86_64-darwin10.8.0]
2012-04-11T20:07:41Z 48401 TID-zrrt3o ERROR: Manager#processor_died died
Connection refused - Unable to connect to Redis on localhost:6379

davidcelis · 2012-04-11T20:25:06Z

The new templated initializer can be found here: https://github.com/davidcelis/recommendable/blob/master/lib/generators/recommendable/templates/initializer.rb

There is a commented out block to configure the Redis connection that Sidekiq will use. It assumes localhost:6379 unless specified, or unless REDISTOGO_URL is specified for Heroku.

davidcelis · 2012-04-11T21:21:15Z

unfortunately, I just had to revert the commit with Sidekiq included, at least for now. I failed to realize that the license was GPL and I would rather not have to license Recommendable under the GPL due to a GPL dependency. Sorry for this brief confusion, but it's back to Resque.

bhardin · 2012-04-11T22:19:42Z

No problem. Totally understand the licensing dealo. Will revert back to resque.

romaind · 2012-04-14T13:02:06Z

Hi there,

Sorry to bother but I can't figure out how to make .recommendations work in my local environment. It keeps returning [].
Everything else works but .recommendations.
My redis/resque setup seems to be ok and similar_raters works well.

I've forked the project and added the foreign keys in acts_as_recommendable.rb just like blackgold9 said but it still won't work !

Did I forget something ?

davidcelis · 2012-04-14T16:50:23Z

@romaind Are you using the most up-to-date version of Recommendable? Or pointing at the github repo?

romaind · 2012-04-14T17:37:16Z

I'm pointing at the github repo in my Gemfile

davidcelis · 2012-04-14T19:33:59Z

@romaind Please open up a new issue on here and describe the problem. Any code/errors you're getting will be helpful. Thanks!

davidcelis closed this as completed in 039ce59 Apr 11, 2012

Not receiving recommendations #7

Not receiving recommendations #7

Comments

bhardin commented Feb 13, 2012

davidcelis commented Feb 13, 2012

bhardin commented Feb 13, 2012

davidcelis commented Feb 13, 2012

bhardin commented Feb 13, 2012

davidcelis commented Feb 13, 2012

bhardin commented Feb 13, 2012

davidcelis commented Feb 13, 2012

bhardin commented Feb 13, 2012

davidcelis commented Feb 13, 2012

bhardin commented Feb 13, 2012

davidcelis commented Feb 13, 2012

bhardin commented Feb 13, 2012

bhardin commented Feb 13, 2012

davidcelis commented Feb 13, 2012

bhardin commented Feb 13, 2012

bhardin commented Feb 14, 2012

davidcelis commented Feb 14, 2012

bhardin commented Feb 14, 2012

davidcelis commented Feb 14, 2012

bhardin commented Feb 14, 2012

davidcelis commented Feb 14, 2012

bhardin commented Feb 14, 2012

davidcelis commented Feb 14, 2012

bhardin commented Feb 14, 2012

davidcelis commented Feb 14, 2012

bhardin commented Feb 14, 2012

davidcelis commented Feb 14, 2012

davidcelis commented Feb 14, 2012

davidcelis commented Feb 14, 2012

bhardin commented Feb 14, 2012

Kelend commented Mar 19, 2012

davidcelis commented Mar 19, 2012

blackgold9 commented Mar 19, 2012

Kelend commented Mar 20, 2012

blackgold9 commented Mar 20, 2012

Kelend commented Mar 24, 2012

davidcelis commented Mar 24, 2012

Kelend commented Mar 26, 2012

davidcelis commented Mar 26, 2012

bhardin commented Apr 10, 2012

bhardin commented Apr 10, 2012

davidcelis commented Apr 10, 2012

Kelend commented Apr 11, 2012

bhardin commented Apr 11, 2012

davidcelis commented Apr 11, 2012

Kelend commented Apr 11, 2012

davidcelis commented Apr 11, 2012

bhardin commented Apr 11, 2012

davidcelis commented Apr 11, 2012

davidcelis commented Apr 11, 2012

bhardin commented Apr 11, 2012

bhardin commented Apr 11, 2012

davidcelis commented Apr 11, 2012

davidcelis commented Apr 11, 2012

bhardin commented Apr 11, 2012

romaind commented Apr 14, 2012

davidcelis commented Apr 14, 2012

romaind commented Apr 14, 2012

davidcelis commented Apr 14, 2012