-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropbox getAuthorizationMethod incorrect #98
Comments
@thomaswelton during my tests, using AUTHORIZATION_METHOD_QUERY_STRING_V2 was working without any problems..I'll check on it again and get back to you ASAP :) |
and this is the moment when I want to kill myself. I commited the wrong version of Dropbox.php, I've changed that to AUTHORIZATION_METHOD_QUERY_STRING but didn't notice and didn't commit it.. |
I know that feeling. @lusitanian this should be good to merge #99 |
Thanks for the fix guys 👍 |
Update dropbox authorization method fixes #98
https://github.com/Lusitanian/PHPoAuthLib/blob/master/src/OAuth/OAuth2/Service/Dropbox.php#L79
The authorization method is listed as being AUTHORIZATION_METHOD_QUERY_STRING_V2 this wasn't working for me when doing
request('account/info');
it makes a URL like this with https://api.dropbox.com/1/account/info?oauth2_access_token=fsSVcJsloq0AAAAAAAAAAfWcHL3iaxAN9XvI1wNObJbQNwtHAx6TdjrrLhvt078Kthe response is
changing it to
AUTHORIZATION_METHOD_QUERY_STRING
works for me, makes the url https://api.dropbox.com/1/account/info?access_token=fsSVcJsloq0AAAAAAAAAAfWcHL3iaxAN9XvI1wNObJbQNwtHAx6TdjrrLhvt078K and properly returns@flavioheleno I see you were to one to kindly provide this class, can you confirm this bug? Are there some requests or actions that may require a different authorization method?
PR to follow to fix the issue I'm having. But I'd like to get some confirmation or do some more testing.
The text was updated successfully, but these errors were encountered: