-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a scheduled GitHub Action to check upstream version #275
Add a scheduled GitHub Action to check upstream version #275
Conversation
Notes:
Here is a scheduled run of the action: https://github.com/jlaine/python-phonenumbers/actions/runs/5642100157 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you – just a couple of minor nits.
Twice a day, a scheduled action checks the latest upstream release and compares it to the current `phonenumbers` version. The check succeeds if and only if the two versions match. Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Thanks to @AA-Turner for all the suggested changes! I think I've addressed all the requested changes, I'd still value your input on whether you want to keep the |
Thanks @jlaine and @AA-Turner ! |
Oh crud. The https://github.com/daviddrysdale/python-phonenumbers/actions/runs/5644422744 |
Yeah, it seems that an |
Twice a day, a scheduled action checks the latest upstream release and compares it to the current
phonenumbers
version. The check succeeds if and only if the two versions match.See #273