Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel transforms to es2015 before publish #29

Closed
wants to merge 2 commits into from
Closed

babel transforms to es2015 before publish #29

wants to merge 2 commits into from

Conversation

hassanshaikley
Copy link

Let me know if this is missing anything! I don't mind doing the same thing for your other PIXI libraries!

@hassanshaikley hassanshaikley mentioned this pull request Jan 4, 2018
Closed
@hassanshaikley
Copy link
Author

Woops. The budo test server is being wonky!

@hassanshaikley
Copy link
Author

There ya go : )

@davidfig
Copy link
Owner

davidfig commented Jan 6, 2018

Hassan, good work! I'm currently in the process of converting pixi-viewport to use more pixi functionality (e.g., PIXI.ticker.shared and PIXI.Interactive). The code is in the pixi-more branch. This change has the advantage of not relying on yy-loop and yy-input, both of which are written in es6.

I'd rather wait to babelify pixi-viewport until that pixi-more moves to master since it will require less work to re-babelify the dependencies that I probably won't support anymore.

If you still want to help, a good place to start the conversion is pixi-ease. (Sorry for the churn!)

A couple of suggestions for your changes:

  • use babel-cli instead of babel
  • use babel-preset-env instead of the es2015
  • the demo should use the /dist files since that's what npm users use

@hassanshaikley
Copy link
Author

I have been meaning to check out that branch and give you feedback! It sounds like the PIXI thing to do.

I don't mind a wait, take your time. Let me know what you think about this PR and if it looks good to do you I will go ahead and do the same with pixi-ease!

@davidfig davidfig closed this Jan 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants