Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix. Preserve non-breaking hyphens. Closes #573. #575

Merged
merged 1 commit into from
May 18, 2024

Conversation

trekonom
Copy link
Contributor

Hej David,

this PR proposes a fix to preserve non-breaking hyphens in docx_summary thereby closing #573.

Basically it replaces <noBreakHyphen> elements with a <t> element containing a hyphen-minus before calling xml_text.

Best S.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.93%. Comparing base (66acdea) to head (f68b5bd).
Report is 9 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #575      +/-   ##
==========================================
+ Coverage   81.73%   82.93%   +1.20%     
==========================================
  Files          40       40              
  Lines        5616     5666      +50     
==========================================
+ Hits         4590     4699     +109     
+ Misses       1026      967      -59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidgohel
Copy link
Owner

Perfect, ty so much again :)

@davidgohel davidgohel merged commit f326c31 into davidgohel:master May 18, 2024
5 checks passed
@trekonom trekonom deleted the issue-573 branch May 18, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants