Parse correct AST attribute for version #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier development versions of Python 3.7 added the docstring field to AST nodes. This was later reverted in Python 3.7.0b5. https://bugs.python.org/issue29463 python/cpython#7121
Codecov Report
@@ Coverage Diff @@
## master #1143 +/- ##
=======================================
Coverage 92.78% 92.78%
=======================================
Files 57 57
Lines 6902 6902
=======================================
Hits 6404 6404
Misses 498 498Continue to review full report at Codecov.
|
|
Great, thanks! |
|
@davidhalter a new sdist is needed on PyPI as the current one fails to build with python 3.7 due to the issue that was fixed here. |
|
New release is coming very soon. I'm just trying to stabilize both jedi and parso. |
|
I released 0.12.1, now. |
|
Awesome! Thanks @davidhalter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier development versions of Python 3.7 added the docstring field to AST nodes. This was later reverted in Python 3.7.0b5.
https://bugs.python.org/issue29463
python/cpython#7121