Make typed decorators work for instance methods #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1826 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 80 80
Lines 11839 11841 +2
=======================================
+ Hits 11186 11188 +2
Misses 653 653
Continue to review full report at Codecov.
|
|
Hrm, the failure here looks to be #1824 |
This feels incomplete when compared to FunctionMixin.py__get__, however seems to work at least in the cut-down reported. Fixes davidhalter#1801.
PeterJCLaw
force-pushed
the
fix-1801-typed-decorator-on-instance-method
branch
from
e576565
to
b6f761f
Compare
|
Thanks! I agree that this is probably incomplete, but it's still good enough. If people are running into issues, they will definitely tell us :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feels incomplete when compared to
FunctionMixin.py__get__, however seems to work at least in the cut-down reported.I've also manually checked that this fixes the more complete version (i.e: with
contextmanager).Fixes #1801.