fix mixing tabs and spaces #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that gcc_register_root_tab has always expected a NULL-terminated table of ggc_root_tab, and we were never NULL-terminating this, so it happened to only ever work by chance. Found when debugging segfaults seen on ARM in all of tests/plugin/gc (https://bugzilla.redhat.com/show_bug.cgi?id=864314); upon applying this patch, all of the tests/plugin/gc go from segfaulting to passing
…her than just decls
|
Sorry, guess I must have based the pull-request on the state of another fork of the repo... |
|
rebase or close imo |
|
Sorry about the delay in responding. The various other commits that showed up above were presumably due to me not properly syncing up from the fedorahosted.org git repo to this github repo. I've redone your fix, and committed it to master as 0f56008. Thanks! |
|
Thank you! |
davidmalcolm
added a commit
that referenced
this pull request
May 4, 2018
davidmalcolm
added a commit
that referenced
this pull request
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.