fix(chains): Fix OpenAIQAWithSourcesChain returning empty strings (#113)

davidmigloz · Aug 12, 2023 · 6181ff8 · 6181ff8
1 parent 3c69adf
commit 6181ff8
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/langchain/lib/src/chains/combine_documents/map_reduce.dart b/packages/langchain/lib/src/chains/combine_documents/map_reduce.dart
@@ -184,6 +184,6 @@ class MapReduceDocumentsChain extends BaseCombineDocumentsChain {
   String _getStringContent(final dynamic content) => switch (content) {
         final String resultStr => resultStr,
         final ChatMessage resultMsg => resultMsg.content,
-        _ => '',
+        _ => content,
       };
 }
diff --git a/packages/langchain/lib/src/chains/combine_documents/stuff.dart b/packages/langchain/lib/src/chains/combine_documents/stuff.dart
@@ -142,7 +142,7 @@ class StuffDocumentsChain extends BaseCombineDocumentsChain {
     final output = switch (llmOutput[llmChain.outputKey]) {
       final String resultStr => resultStr,
       final ChatMessage resultMsg => resultMsg.content,
-      _ => '',
+      _ => llmOutput[llmChain.outputKey],
     };
     return {
       outputKey: output,

diff --git a/packages/langchain_openai/test/chains/qa_with_sources_test.dart b/packages/langchain_openai/test/chains/qa_with_sources_test.dart
@@ -17,7 +17,7 @@ void main() {
       const loader = TextLoader(filePath);
       final documents = await loader.load();
 
-      const textSplitter = CharacterTextSplitter(
+      const textSplitter = RecursiveCharacterTextSplitter(
         chunkSize: 800,
         chunkOverlap: 0,
       );