Issue GoogleCloudDataproc#1099: Fixing the usage of ExternalAccountCr…

…edentials
davidrabinowitz · Oct 23, 2023 · aae5b5a · aae5b5a
1 parent cbcd5ae
commit aae5b5a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGES.md b/CHANGES.md
@@ -5,6 +5,7 @@
 * PR #1057: Enable async writes for greater throughput
 * PR #1094: CVE-2023-5072: Upgrading the org.json:json dependency
 * PR #1095: CVE-2023-4586: Upgrading the netty dependencies
+* Issue #1099: Fixing the usage of ExternalAccountCredentials
 * BigQuery API has been upgraded to version 2.33.2
 * BigQuery Storage API has been upgraded to version 2.44.0
 * GAX has been upgraded to version 2.35.0

diff --git a/...ommon/src/main/java/com/google/cloud/bigquery/connector/common/BigQueryClientFactory.java b/...ommon/src/main/java/com/google/cloud/bigquery/connector/common/BigQueryClientFactory.java
@@ -35,6 +35,7 @@
 import java.io.IOException;
 import java.io.Serializable;
 import java.io.UncheckedIOException;
+import java.util.Arrays;
 import java.util.HashMap;
 import java.util.Map;
 import java.util.Optional;
@@ -112,7 +113,7 @@ public int hashCode() {
     // ExternalAccountCredentials first and then compare their hashCodes.
     if (credentials instanceof ExternalAccountCredentials) {
       return Objects.hashCode(
-          BigQueryUtil.getCredentialsByteArray(credentials),
+          Arrays.hashCode(BigQueryUtil.getCredentialsByteArray(credentials)),
           headerProvider,
           bqConfig.getClientCreationHashCode());
     }