Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ViewController #32

Merged
merged 1 commit into from
May 8, 2016
Merged

Conversation

bbrock25
Copy link
Contributor

@bbrock25 bbrock25 commented May 8, 2016

Why?

The project would not build...

In the chan.on("error") block we were referencing self.chat.text rather
than self.chatWindow.text.

How?

replaced the reference to self.chat.text with self.chatWindow.text

Side Effects?

seems to be operational, however I'm gettign kicked off of the phoenix
chat server after about 30 seconds. I wonder if this has to do with the
previous commit that relates to the heartbeat

An Aside...

Thank you very much for the work on this library, I have been working with elixir off and on for about 6 months and am really motivated to get more involved writing more native apps. If there is any way that I can assist you in the development of this library, please let me know! Any small fixes or issues to get started would be much appreciated.

_Why_?

The project would not build...

In the chan.on("error") block we were referencing self.chat.text rather
than self.chatWindow.text.

_How_?

replaced the reference to self.chat.text with self.chatWindow.text

_Side Effects_?

seems to be operational, however I'm gettign kicked off of the phoenix
chat server after about 30 seconds. I wonder if this has to do with the
previous commit that relates to the heartbeat
@davidstump
Copy link
Owner

Awesome - Thanks for catching my typo!

The previous commit sounds like it could be related since it sends a heartbeat every 30s to the Phoenix instance, however, even if there is nothing to handle the heartbeat it should just produce an error in the log and not kick you off the server. Are you getting any errors from the Phoenix side?

Glad you are enjoying Elixir and Swift! I would always love any help, feedback, updates on the client you would like to provide. Other than the current issue you mentioned (heartbeat) the next main items are adding Carthage support and Tests (more than zero would be awesome).

Cheers!

@davidstump davidstump merged commit dd4623d into davidstump:master May 8, 2016
@bbrock25
Copy link
Contributor Author

bbrock25 commented May 8, 2016

Thanks for the merge!

I'll take a deeper look, I wasn't getting any obvious errors on the phienix side, but I didn't go too deep either. I'm definitely in the learning stages of swift, so tests will be a great first step.

@bbrock25 bbrock25 mentioned this pull request May 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants