Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed external json lib and replaced it with native ios parsing #49

Closed
wants to merge 1 commit into from

Conversation

NilsLattek
Copy link
Contributor

Fixes the issues mentioned in #48
This should also allow libraries like SwiftyJSON or Gloss to parse Phoenix.Message.message.

@davidstump
Copy link
Owner

davidstump commented Aug 15, 2016

Wow - thanks for the quick PR!  ❤️

I'll check it out as soon as I can and get it merged.

Cheers.

@NilsLattek
Copy link
Contributor Author

You're welcome, take your time, I am going to use my branch in the meantime 😄

@NilsLattek NilsLattek mentioned this pull request Aug 23, 2016
@BryanJBryce
Copy link

@NilsLattek Don't forget Marshal, Swifty is not very swift: https://github.com/bwhiteley/JSONShootout

@NilsLattek
Copy link
Contributor Author

Any parsing library which accepts a dictionary or array from NSJSONSerialization.JSONObjectWithData should work. Looking at the JSONShootout examples this should work.

@davidstump
Copy link
Owner

I went ahead and tested the Swift 3 updates and pushed them to master to fast track getting this library working with the current versions. Unfortunately this is going to cause a few issues with the native json parsing in this PR. I can look at updating it when I have a few mins, but would appreciate it if you happen to have some time to update the PR to the new syntax.

Thanks as always!

@NilsLattek
Copy link
Contributor Author

Puuh too many merge conflicts when I try to merge master into this branch. I guess it would make sense to delete the branch/PR and reapply the changes to master.
I might have a look in the next weeks, but I am also quite busy with upgrading swift version in my projects...

AquaGeek added a commit to AquaGeek/SwiftPhoenixClient that referenced this pull request Oct 7, 2016
@AquaGeek AquaGeek mentioned this pull request Oct 7, 2016
@davidstump davidstump closed this Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants