-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP8; added command line argument for password length; added command lin... #1
Conversation
…line argument for version; added trove classifiers; added docstrings
1 similar comment
Thanks Thomas! There is an edge case where the password generator will not generate a custom length password: >>> len(generate_password(35))
32 That is because after the |
…ent; added test case for this
I think I fixed this issue. (my name is Martin, not "Thomas". "Thoma" (without s) is my last name) |
2 similar comments
Martin, I'm really sorry for the name mistake! I didn't even write your last name correct 😞 While the test passes, the problem persists, what about: >>> len(generate_password(33))
32 maybe we should change from |
2 similar comments
No problem.
Ok. I thought it would only have one dash in it. I think I fixed it now and the test covers all passwords between 2 and 160 characters. |
PEP8; added command line argument for password length; added command line argument for version; added trove classifiers; added docstrings
...e argument for version; added trove classifiers; added docstrings