Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8; added command line argument for password length; added command lin... #1

Merged
merged 3 commits into from
Mar 31, 2015
Merged

Conversation

MartinThoma
Copy link
Contributor

...e argument for version; added trove classifiers; added docstrings

…line argument for version; added trove classifiers; added docstrings
@coveralls
Copy link

Coverage Status

Coverage decreased (-12.5%) to 87.5% when pulling fc37d85 on MartinThoma:master into cc2ce2b on davoclavo:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-12.5%) to 87.5% when pulling fc37d85 on MartinThoma:master into cc2ce2b on davoclavo:master.

@davoclavo
Copy link
Owner

Thanks Thomas!

There is an edge case where the password generator will not generate a custom length password:

>>> len(generate_password(35))
32

That is because after the uuid4() call there is a string replacement that removes hyphens

@MartinThoma
Copy link
Contributor Author

I think I fixed this issue. (my name is Martin, not "Thomas". "Thoma" (without s) is my last name)

@coveralls
Copy link

Coverage Status

Coverage decreased (-11.11%) to 88.89% when pulling 6b877ea on MartinThoma:master into cc2ce2b on davoclavo:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-11.11%) to 88.89% when pulling 6b877ea on MartinThoma:master into cc2ce2b on davoclavo:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-11.11%) to 88.89% when pulling 6b877ea on MartinThoma:master into cc2ce2b on davoclavo:master.

@davoclavo
Copy link
Owner

Martin, I'm really sorry for the name mistake! I didn't even write your last name correct 😞

While the test passes, the problem persists, what about:

>>> len(generate_password(33))
32

maybe we should change from str(uuid4()) to uuid4().hex, which already removes the hyphens, so we won't even need to do the replacement afterwards

@coveralls
Copy link

Coverage Status

Coverage decreased (-10.71%) to 89.29% when pulling 656903f on MartinThoma:master into cc2ce2b on davoclavo:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-10.71%) to 89.29% when pulling 656903f on MartinThoma:master into cc2ce2b on davoclavo:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-10.71%) to 89.29% when pulling 656903f on MartinThoma:master into cc2ce2b on davoclavo:master.

@MartinThoma
Copy link
Contributor Author

Martin, I'm really sorry for the name mistake! I didn't even write your last name correct 😞

No problem.

While the test passes, the problem persists

Ok. I thought it would only have one dash in it. I think I fixed it now and the test covers all passwords between 2 and 160 characters.

davoclavo added a commit that referenced this pull request Mar 31, 2015
PEP8; added command line argument for password length; added command line argument for version; added trove classifiers; added docstrings
@davoclavo davoclavo merged commit c0fa677 into davoclavo:master Mar 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants