Skip to content
View davunderscorei's full-sized avatar
2 followers · 4 following
  • London

Achievements

Achievement: Arctic Code Vault Contributor

Achievements

Achievement: Arctic Code Vault Contributor

Block or report davunderscorei

Block user

Prevent this user from interacting with your repositories and sending you notifications. Learn more about blocking users.

You must be logged in to block users.

Please don't include any personal information such as legal names or email addresses. Maximum 100 characters, markdown supported. This note will be visible to only you.
Report abuse

Contact GitHub support about this user’s behavior. Learn more about reporting abuse.

Report abuse
davunderscorei/README.md

How I review Pull Requests

Comments on Pull Requests aren't all equal - some are more important than other. However, visually they are all the same. In order to tackle this I use the following "traffic light" approach to comments:

  • 🟩 COULD resolve in this PR - might be more of a subjective style or suggestion. Feel free to implement, discuss or ignore.
  • 🔶 SHOULD resolve in this PR - this is something where there is a compelling reason to make improvements. Ideally should be commented on but merging can proceed without implementation.
  • 🔴 MUST resolve in this PR - this is something breaking, wrong, or likely to cause substantial misunderstanding. PR won't be accepted until either an agreement is reached or the code is changed

Popular repositories Loading

  1. dotfiles dotfiles Public

    Useful dotfiles

    Vim Script 1

  2. Neuretix-Win Neuretix-Win Public

    Forked from Bam4d/Neuretix-Win

    Windows version of the Neuretix software.

    C++

  3. kudu kudu Public

    Forked from projectkudu/kudu

    Kudu is the engine behind git deployments in Azure Web Sites. It can also run outside of Azure.

    C#

  4. ncommon ncommon Public

    Forked from riteshrao/ncommon

    A framework for implementing commonly used design patterns when using Domain Driven Design

    C#

  5. anQular.js anQular.js Public

    Making angular.js and jQuery play nice.

  6. tab-hq-react tab-hq-react Public

    Forked from theappbusiness/tab-hq

    CSS