Ensure Presenter height never grows beyond screen height #4
Conversation
Otherwise, the fullscreening may be broken in odd ways, at least in Gnome 3. We give the current slide view up to 0.9*0.8 of the height and the strict views up to 0.9*0.2 (minus padding) of the height, with the status bar at the bottom getting the last 0.1. We look at the size request for the current view and set the width of the next view to fill the remaining space (and hope that the allocation will be as requested).
This ensures that it doesn't grow in height and change the window's total height, which can mess up the full-screen effect.
|
Thanks for the patch! For the notes I can see the problem is solved. For the slides I do not have a real-life example to work on and test it. Could you PM some slides where the problem occurs? I tried opening a "book" (i.e. several portrait A4 pages) and the window was resized in a strange way, but this is not a case we should concentrate on, I think. Although it should not break there either... |
|
Try launching a normal presentation with '-u 90'. With a wide-screen monitor, I actually had problems with the default settings. I can send you screenshots, if that would help. |
|
Merged. There may still problems with patological cases though, e.g. when opening A4 pages. With normal usage there shouldn't be issues, but I will add similar checks also for the preview so that pdfpc is more robust. |
A full-screen window that has a height greater than the screen height experiences all sorts of weird, wonderful breakage, at least in Gnome 3. I found two ways in which this could happen:
These commits fix both issues.