Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextSelectionOverwrite #44

Merged
merged 5 commits into from
May 7, 2022
Merged

TextSelectionOverwrite #44

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8fa92cf
Overwrite selection. In case of multiple selections, first one will b…
rapsalands Apr 26, 2020
0fa27ba
Adding comments.
rapsalands Apr 26, 2020
b348b60
reverting changes in package.json
rapsalands Apr 27, 2020
b535c72
Package.lock file reverted.
rapsalands Apr 27, 2020
a3f8290
Merge remote-tracking branch 'origin/master' into OverwriteBranch
dawsbot May 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,15 @@ class RelativePath {

window.activeTextEditor.edit(
(editBuilder: TextEditorEdit) => {
let position: Position = window.activeTextEditor.selection.end;
editBuilder.insert(position, relativeUrl);
// Get all selections
let selections = window.activeTextEditor.selections;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you teach me about how selections can be an array? I would assume this is just a string containing the characters currently highlighted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User may select a text (let's say 'pdf') and press Ctrl+D, this selects all the 'pdf' text in that file. This will lead to multiple selections.


// Replace selections with relative Url.
selections.forEach(sel => {
editor.edit(editBuilder => {
editBuilder.replace(sel, relativeUrl);
});
});
}
);
}
Expand Down