Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login With Unstoppable Domain integration #1

Closed
wants to merge 2 commits into from

Conversation

ayush035
Copy link

No description provided.

@vercel
Copy link

vercel bot commented Aug 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
drain ✅ Ready (Inspect) Visit Preview Aug 24, 2022 at 2:03PM (UTC)

@dawsbot
Copy link
Owner

dawsbot commented Aug 24, 2022

Hey @ayush035, thanks for the PR.

Unfortunately I don't understand the use-case because the unstoppable button you've added presents the users with the same options (MetaMask or WalletConnect). In addition, this integration adds 133kb from @uauth/js which slows down the site for folks in emerging markets.

Help me understand what this new button adds for users.

@ayush035
Copy link
Author

ayush035 commented Aug 24, 2022 via email

@dawsbot
Copy link
Owner

dawsbot commented Aug 24, 2022

@ayush035 Luckily, on Drain, you never need to type out any addresses. When you connect via MetaMask or WalletConnect, Drain pulls in your address.

Is there anything I misunderstand here?

It seems there's an Unstoppable Domain wallet that is now usable thanks to this PR? If that's the case, can you instead connect to that wallet via WalletConnect?

@ayush035
Copy link
Author

ayush035 commented Aug 24, 2022 via email

@dawsbot
Copy link
Owner

dawsbot commented Aug 26, 2022

@ayush035 the solution of resolving unstoppable domains at the bottom for the recipient sounds like a useful PR.

Let's do that, I'll close this PR for now since it adds a lot to the web bundle and slows page loads 🙏

@dawsbot dawsbot closed this Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants