Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 footer fix #248

Merged
merged 3 commits into from
Jun 8, 2023
Merged

🐛 footer fix #248

merged 3 commits into from
Jun 8, 2023

Conversation

jtfirek
Copy link
Collaborator

@jtfirek jtfirek commented Jun 6, 2023

Right element was not aligned correctly and I removed some earnify things
before:
Screen Shot 2023-06-06 at 3 29 35 PM
After:
Screen Shot 2023-06-06 at 4 58 08 PM

@vercel
Copy link

vercel bot commented Jun 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
essential-eth ❌ Failed (Inspect) Jun 7, 2023 1:41am

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5322439) 91.08% compared to head (f02c19e) 91.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #248   +/-   ##
=======================================
  Coverage   91.08%   91.08%           
=======================================
  Files          42       42           
  Lines        1043     1043           
  Branches      290      290           
=======================================
  Hits          950      950           
  Misses         84       84           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dawsbot
Copy link
Owner

dawsbot commented Jun 6, 2023

Please include mobile screenshots as-well for all UI changes. I'd like to know how this changes mobile @jtfirek 🙏

@jtfirek
Copy link
Collaborator Author

jtfirek commented Jun 7, 2023

Sounds good! I added some more rules to improve the look on mobile:
before:
Screen Shot 2023-06-07 at 10 35 05 AM

after:
Screen Shot 2023-06-07 at 10 32 22 AM

@dawsbot dawsbot merged commit bcadafc into master Jun 8, 2023
@dawsbot dawsbot deleted the doc-footer-fix branch June 8, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants