Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull basescan #29

Closed
1 of 4 tasks
dawsbot opened this issue Mar 25, 2024 · 0 comments · Fixed by #39
Closed
1 of 4 tasks

Pull basescan #29

dawsbot opened this issue Mar 25, 2024 · 0 comments · Fixed by #39
Assignees
Labels
enhancement New feature or request

Comments

@dawsbot
Copy link
Owner

dawsbot commented Mar 25, 2024

  • Move html selections to a separate class that's testable (working on this in 🧪 Add unit testing via vitest #30 )
  • Add testing for all etherscan selectors to ensure we keep selecting those fully functioning
  • Add testing for basescan (will be broken at first since etherscan selectors don't work for addresses)
  • Fix basescan tests so the selectors do work for basescan
@dawsbot dawsbot added the enhancement New feature or request label Mar 25, 2024
@dawsbot dawsbot self-assigned this Mar 25, 2024
dawsbot added a commit that referenced this issue Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant