Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: let hitRate prop can take function #139

Merged
merged 1 commit into from
Jun 19, 2023
Merged

feat: let hitRate prop can take function #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/selecto/src/SelectoManager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,10 +583,15 @@ class Selecto extends EventEmitter<SelectoEvents> {
[right, bottom],
[left, bottom],
];
const hitRateValue = splitUnit(`${hitRate}`);

const isHit = (points: number[][], el: Element) => {
const inArea = ignoreClick ? false : isInside([clientX, clientY], points);
const hitRateValue =
typeof hitRate === "function"
? splitUnit(`${hitRate(el)}`)
: splitUnit(`${hitRate}`);

const inArea = ignoreClick
? false
: isInside([clientX, clientY], points);

if (selectByClick && inArea) {
return true;
Expand Down
2 changes: 1 addition & 1 deletion packages/selecto/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export interface SelectoOptions {
* The rate at which the target overlaps the drag area to be selected. If you want an absolute number, set it to a px value. (ex: 10px)
* @default 100
*/
hitRate: number | string;
hitRate: number | string | ((element: Element) => number | string);
/**
* Container to bound the selection area. If false, do not bound. If true, it is the container of selecto.
* @default false
Expand Down