Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add gitness provider #689

Merged
merged 1 commit into from
Jun 21, 2024
Merged

feat: add gitness provider #689

merged 1 commit into from
Jun 21, 2024

Conversation

Rutik7066
Copy link
Contributor

@Rutik7066 Rutik7066 commented Jun 17, 2024 •
edited by Tpuljak
Loading

feat: add gitness provider

  • This change requires a documentation update
  • I have made corresponding changes to the documentation

Related Issue(s)

Closes #561
/claim #561

@Rutik7066 Rutik7066 marked this pull request as ready for review June 17, 2024 19:49
@Rutik7066 Rutik7066 requested a review from a team as a code owner June 17, 2024 19:49
Tpuljak
Tpuljak requested changes Jun 18, 2024
View reviewed changes
cmd/daytona/config/const.go Show resolved Hide resolved
pkg/gitprovider/git_provider.go Outdated Show resolved Hide resolved
pkg/gitprovider/gitness.go Outdated Show resolved Hide resolved
pkg/gitprovider/gitness_test.go Outdated Show resolved Hide resolved
pkg/gitnessclient/gitness_client_test.go Outdated Show resolved Hide resolved
@Rutik7066 Rutik7066 force-pushed the main branch 2 times, most recently from 4514867 to 16ec54d Compare June 18, 2024 08:15
@Tpuljak
Copy link
Member

Tpuljak commented Jun 18, 2024

@Rutik7066 the git file tree seems to be messed up again. Please rebase the changes into one commit that is signed so we can properly review.

@Rutik7066
Copy link
Contributor Author

@Tpuljak I am trying do rebase and signoff but failing to do so.

@Rutik7066
Copy link
Contributor Author

@Tpuljak Done

@algora-pbc algora-pbc bot mentioned this pull request Jun 18, 2024
Closed
Tpuljak
Tpuljak requested changes Jun 19, 2024
View reviewed changes
Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rutik7066 nice work. This is progressing nicely. I managed to create a couple of workspaces using different URLs.

There are still a couple of issues that should be addressed that I commented below. I'll put the PR in draft while you address them. Mark the PR as ready for review when you're done with the changes.

pkg/gitnessclient/gitness_client.go Outdated Show resolved Hide resolved
pkg/gitnessclient/gitness_client.go Outdated Show resolved Hide resolved
pkg/gitnessclient/gitness_client.go Outdated Show resolved Hide resolved
pkg/gitnessclient/gitness_client.go Outdated Show resolved Hide resolved
pkg/gitprovider/gitness.go Outdated Show resolved Hide resolved
pkg/gitprovider/gitness.go Show resolved Hide resolved
@Tpuljak Tpuljak marked this pull request as draft June 19, 2024 07:57
@Rutik7066 Rutik7066 marked this pull request as ready for review June 19, 2024 10:41
@Rutik7066
Copy link
Contributor Author

@Tpuljak I Have made the changes and ameded them to the commit. You can review the changes.

Tpuljak
Tpuljak requested changes Jun 20, 2024
View reviewed changes
pkg/gitnessclient/gitness_client.go Outdated Show resolved Hide resolved
Tpuljak
Tpuljak requested changes Jun 20, 2024
View reviewed changes
pkg/gitprovider/gitness.go Show resolved Hide resolved
@Tpuljak Tpuljak mentioned this pull request Jun 20, 2024
Closed
Tpuljak
Tpuljak requested changes Jun 20, 2024
View reviewed changes
Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rutik7066 everything seems to be working functionally. Nice work!

I left one more suggestion to improve the quality and maintainability of the code.

pkg/gitnessclient/gitness_client.go Outdated Show resolved Hide resolved
@Rutik7066 Rutik7066 force-pushed the main branch 3 times, most recently from e76c269 to 97e5959 Compare June 20, 2024 09:46
Tpuljak
Tpuljak approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be in order. Nice work!

@Tpuljak Tpuljak added the docs: needs update This PR requires the Daytona Docs to be updated label Jun 20, 2024
idagelic
idagelic requested changes Jun 20, 2024
View reviewed changes
Copy link
Member

@idagelic idagelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Rutik7066! I tested out the git provider and it works nicely.
We would love to release this today - there are just some minor code fixes to address so please go through them.

Thank you

cmd/daytona/config/const.go Show resolved Hide resolved
pkg/gitnessclient/gitness_client.go Show resolved Hide resolved
pkg/gitnessclient/gitness_client.go Outdated Show resolved Hide resolved
pkg/gitnessclient/gitness_client.go Outdated Show resolved Hide resolved
pkg/gitnessclient/gitness_client.go Outdated Show resolved Hide resolved
pkg/gitprovider/gitness.go Outdated Show resolved Hide resolved
pkg/gitprovider/gitness.go Outdated Show resolved Hide resolved
pkg/views/gitprovider/select.go Outdated Show resolved Hide resolved
pkg/gitnessclient/gitness_types.go Outdated Show resolved Hide resolved
pkg/gitnessclient/gitness_client.go Show resolved Hide resolved
@Rutik7066
Copy link
Contributor Author

@idagelic Sure I will update the code in 2-3 hours

@Rutik7066 Rutik7066 force-pushed the main branch 2 times, most recently from 78292e3 to 41d6f64 Compare June 20, 2024 20:04
@Rutik7066
Copy link
Contributor Author

@idagelic All changes are applied as requested please review and let me know if anything needs to be changed. I'm just waiting for you to confirm.

idagelic
idagelic requested changes Jun 20, 2024
View reviewed changes
Copy link
Member

@idagelic idagelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the Gitness provider to README.md - there are two places, you can search for the term "Gitea" to find the place where you should add Gitness

pkg/gitnessclient/gitness_client.go Show resolved Hide resolved
@Rutik7066
Copy link
Contributor Author

@idagelic I updated all the changes. You can review them now.

@Rutik7066 Rutik7066 requested a review from idagelic June 21, 2024 07:38
@Rutik7066
feat: add gitness provider
1c6a5ca 
Signed-off-by: rutik7066 <rutikthakre@gmail.com>
@Rutik7066 Rutik7066 requested a review from a team as a code owner June 21, 2024 08:28
@idagelic idagelic merged commit 9682edf into daytonaio:main Jun 21, 2024
12 checks passed
@osslate osslate mentioned this pull request Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idagelic idagelic idagelic approved these changes

@Tpuljak Tpuljak Tpuljak approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim docs: needs update This PR requires the Daytona Docs to be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gitness Support
3 participants
@Rutik7066 @Tpuljak @idagelic