Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sidebar icons #25

Merged
merged 3 commits into from
May 30, 2024
Merged

Update sidebar icons #25

merged 3 commits into from
May 30, 2024

Conversation

osslate
Copy link
Contributor

@osslate osslate commented May 27, 2024

Fixes #20.

Fixes #20.

Signed-off-by: Fionn Kelleher <fionn@daytona.io>
Copy link
Member

@ivan-burazin ivan-burazin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@osslate please use the same icons from https://www.daytona.io/docs/

To be specific:

  1. Workspaces Icon is using IDE icon.
  2. Server Icon is wrong or missing (there is a whole pallet of icons you can use)
  3. Installation we need a logo like this cc @mikimih https://banner2.cleanpng.com/20180329/qgw/kisspng-computer-icons-installation-download-flat-design-soft-5abd33db1f5a87.7486819515223490191284.jpg

@mikimih
Copy link
Contributor

mikimih commented May 29, 2024

installation

@ivan-burazin Attached is the icon you requested in SVG format.

Please note that this icon was selected from a different library, but it fits well stylistically with our existing icons. If you know the source from which Nicolas sourced our current icons, please let us know.

@osslate
Copy link
Contributor Author

osslate commented May 29, 2024

Hi @mikimih, thanks for the icon. I added the icon locally and tested it out, but it looks like there's extra padding in the SVG compared with the others (so it looks smaller).

Could you fix this and send on an updated icon?

image

@osslate
Copy link
Contributor Author

osslate commented May 29, 2024

@ivan-burazin @mikimih I can't find an icon suitable for Server in the icons that exist in the repo. The closest I can find it the one I used here (computer.svg) but that's also the Workspaces icon.

Signed-off-by: Fionn Kelleher <fionn@daytona.io>
@nsolerieu
Copy link

@ivan-burazin I used an icon pack as a base set for daytona product: Mono icons

For more dev tools specific one like like the (CLI, CPU) I used GitHub open source Octicons

And in some cases I made some custom ones to fit with the 2 sets above (GPU)

For install I recommend using Mono icon share as a base and reverse it like this:

Screenshot 2024-05-29 at 9 36 42 AM

install SVG asset

@ivan-burazin
Copy link
Member

thank you @nsolerieu 🙇

@osslate are we set now?

Signed-off-by: Fionn Kelleher <fionn@daytona.io>
@osslate osslate merged commit 9f97cc9 into main May 30, 2024
1 check passed
@osslate osslate deleted the sidebar-icons branch May 30, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update navigation items with appropriate icons
5 participants