Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.js #31

Closed
wants to merge 1 commit into from
Closed

Conversation

PragmaWolf
Copy link

This is little fix help me with [ERROR] TypeError: Invalid Version: 10.2 (Ubuntu 10.2-1.pgdg16.04+1).0

This is little fix help me with `[ERROR] TypeError: Invalid Version: 10.2 (Ubuntu 10.2-1.pgdg16.04+1).0`
@ghost
Copy link

ghost commented Feb 12, 2018

There were the following issues with this Pull Request

  • Commit: 2c72dff
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding!

@wzrdtales
Copy link
Member

Thanks for your first contribution! 🎉

First thing to notice, please comply to the DCO and commit conventions (angular).

Second thing:
Are you sure that this patch is needed? If yes please explain why, did you tested before with the latest version? We just recently accepted #27 which should not evaluate strings like the one you posted anymore.

Can you provide more knowledge about your environment please?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants