-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
miscellaneous improvements from the repair branch #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reopening this to trigger the pipeline again. maybe we should change the github action workflow to make this less annoying? |
Closed
should pass now, clang seems to have differing opinions on the interactions between parameter pack deduction and default arguments |
cmrschwarz
force-pushed
the
repair
branch
3 times, most recently
from
May 24, 2023 21:33
6f1941c
to
5b29696
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bundles some minor improvements that piled up on the repair branch:
allow specifying default values for
additional_simd_template_parameter
additional_non_specialized_template_parameters
fix the
gather
primitive making use of the new defaults and add testing for itfix unit test case generation for tests that specify an
additional_simd_template_parameter
improvements for tests helper functions
integral_type_t
rnd_init_bounded
test_memory_helper_t
constructorsproper 4 space indenting in generated files + other whitespace cleanups