Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miscellaneous improvements from the repair branch #37

Merged
merged 9 commits into from
May 25, 2023

Conversation

cmrschwarz
Copy link
Contributor

This PR bundles some minor improvements that piled up on the repair branch:

  • allow specifying default values for

    • additional_simd_template_parameter
    • additional_non_specialized_template_parameters
  • fix the gather primitive making use of the new defaults and add testing for it

  • fix unit test case generation for tests that specify an additional_simd_template_parameter

  • improvements for tests helper functions

    • added integral_type_t
    • added rnd_init_bounded
    • fixed additional arg passing in test_memory_helper_t constructors
  • proper 4 space indenting in generated files + other whitespace cleanups

@cmrschwarz
Copy link
Contributor Author

cmrschwarz commented May 23, 2023

reopening this to trigger the pipeline again. maybe we should change the github action workflow to make this less annoying?

@cmrschwarz cmrschwarz closed this May 23, 2023
@cmrschwarz cmrschwarz reopened this May 23, 2023
@JPietrzykTUD JPietrzykTUD mentioned this pull request May 23, 2023
@cmrschwarz
Copy link
Contributor Author

cmrschwarz commented May 23, 2023

should pass now, clang seems to have differing opinions on the interactions between parameter pack deduction and default arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants