Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: guidelines 3.0 link style #89

Merged
merged 19 commits into from
Jan 12, 2023
Merged

refactor: guidelines 3.0 link style #89

merged 19 commits into from
Jan 12, 2023

Conversation

dkolba
Copy link
Collaborator

@dkolba dkolba commented Oct 12, 2022 •
edited by annsch
Loading

BREAKING CHANGE: 🧨 Brace yourselves - all your links are belong to us 🔗

Closes #90

Additionally

  • docs/migrationGuide.adoc
  • Test-URLs: .pa11yci and tests/backstop.json

@mfranzke mfranzke assigned mfranzke and dkolba and unassigned mfranzke Oct 12, 2022
@mfranzke mfranzke added this to the Guidelines 3.0 milestone Oct 12, 2022
@dkolba dkolba force-pushed the feat-dbswc-323-link branch 2 times, most recently from 18c74b5 to 416ea0c Compare November 9, 2022 13:36
@annsch annsch changed the title feat: 🎸 Link according to DBUX-3 spec refactor: guidelines 3.0 link Dec 7, 2022
@annsch annsch changed the title refactor: guidelines 3.0 link refactor: guidelines 3.0 link style Dec 7, 2022
@annsch annsch self-assigned this Dec 8, 2022
@mfranzke mfranzke mentioned this pull request Dec 12, 2022
Open
mfranzke
mfranzke previously approved these changes Dec 13, 2022
View reviewed changes
@annsch annsch requested a review from mfranzke January 6, 2023 11:03
@mfranzke
Copy link
Member

mfranzke commented Jan 7, 2023

Preview URL: https://db-ui.github.io/core/review/feat-dbswc-323-link/?p=viewall-elements-link

@mfranzke mfranzke mentioned this pull request Jan 11, 2023
Open
@mfranzke mfranzke enabled auto-merge (squash) January 12, 2023 10:45
@mfranzke mfranzke merged commit e826142 into dbux-3 Jan 12, 2023
@mfranzke mfranzke deleted the feat-dbswc-323-link branch January 12, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke approved these changes

@nmerget nmerget Awaiting requested review from nmerget nmerget is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees

@dkolba dkolba

@annsch annsch

Labels
improvement patterns
Projects
None yet
Milestone
Guidelines v3
Development

Successfully merging this pull request may close these issues.
3 participants
@dkolba @mfranzke @annsch