Feat tabs design changes no span #2472

nmerget · 2024-04-08T11:20:10Z

Proposed changes

removed span

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Refactoring (fix on existing components or architectural decisions)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Update (if none of the other choices apply)

github-actions · 2024-04-08T11:20:25Z

packages/components/src/components/tab/tab.lite.tsx

nmerget added 2 commits April 8, 2024 12:44

fix: removed span from tab

785d015

fix: removed class name for ul tag

263df99

nmerget requested review from mfranzke, dkolba and annsch as code owners April 8, 2024 11:20

nmerget requested review from bruno-sch and removed request for dkolba, mfranzke and annsch April 8, 2024 11:20

nmerget and others added 2 commits April 8, 2024 15:07

fix: issue with centered icons

d4d22e8

test: updatet screenshots

8a48e67

mfranzke merged commit 1ad40da into feat-tabs-design-changes Apr 9, 2024
22 checks passed

mfranzke deleted the feat-tabs-design-changes-no-span branch April 9, 2024 05:56

mfranzke reviewed Apr 9, 2024

View reviewed changes

packages/components/src/components/tab/tab.lite.tsx Show resolved Hide resolved

mfranzke mentioned this pull request Apr 9, 2024

tabs: role="tab"-attribute placement #2476

Open