Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat tabs design changes no span #2472

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Feat tabs design changes no span #2472

merged 4 commits into from
Apr 9, 2024

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Apr 8, 2024

Proposed changes

removed span

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget requested review from bruno-sch and removed request for dkolba, mfranzke and annsch April 8, 2024 11:20
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/feat-tabs-design-changes-no-span

@mfranzke mfranzke merged commit 1ad40da into feat-tabs-design-changes Apr 9, 2024
22 checks passed
@mfranzke mfranzke deleted the feat-tabs-design-changes-no-span branch April 9, 2024 05:56
@mfranzke mfranzke mentioned this pull request Apr 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke left review comments

@bruno-sch bruno-sch Awaiting requested review from bruno-sch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmerget @mfranzke