test: add a11y tests to showcases #2581

nmerget · 2024-04-25T14:19:28Z

Proposed changes

closes #2571

Types of changes

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Refactoring (fix on existing components or architectural decisions)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Update (if none of the other choices apply)

Further comments

github-actions · 2024-04-25T14:19:45Z

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/test-a11y-showcases

package.json

...ts__/notification/showcase/webkit/regular/neutral/DBNotification-should-match-screenshot.png

# Conflicts: # package-lock.json # showcases/angular-showcase/src/app/components/navigation-item/navigation-item.component.html # showcases/react-showcase/src/components/navigation-item/index.tsx

packages/components/src/components/tab-item/tab-item.lite.tsx

showcases/e2e/fixtures/hover.ts

packages/components/src/components/popover/popover.scss

packages/components/src/components/tooltip/tooltip.scss

packages/components/src/components/tabs/tabs.spec.tsx

Co-authored-by: Maximilian Franzke <787658+mfranzke@users.noreply.github.com>

packages/components/src/components/tab-item/tab-item.lite.tsx

showcases/e2e/home/showcase-home.spec.ts

showcases/react-showcase/src/components/index.tsx

package.json

Co-authored-by: Maximilian Franzke <787658+mfranzke@users.noreply.github.com>

# Conflicts: # __snapshots__/section/showcase/mobile-chrome/regular/neutral/DBSection-should-match-screenshot.png

test: add a11y tests to showcases

ea9dc54

github-actions bot added the 📺showcases Changes to 1-n showcases label Apr 25, 2024

nmerget added 2 commits April 25, 2024 16:51

test: a11y test showcase only watch main

a9814c5

test: add test for home screen

fc81c02

mfranzke reviewed Apr 25, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

fix: a11y issues for notification and tab-item

5cec4ad

github-actions bot added the 🏘components Changes inside components folder label Apr 26, 2024

nmerget added 3 commits April 26, 2024 11:56

fix: issue with ts miss match

0690fb6

fix: issues with a11y tests in showcases

3e42967

fix: issues with a11y tests in showcases

f0bc30d

github-actions bot added the 🚢📀cicd Changes inside .github folder label Apr 26, 2024

mfranzke reviewed Apr 26, 2024

View reviewed changes

...ts__/notification/showcase/webkit/regular/neutral/DBNotification-should-match-screenshot.png Outdated Show resolved Hide resolved

nmerget added 6 commits April 26, 2024 14:18

fix: try to fix issues with a11y tests

2f4bccf

fix: some playwright issues

65b9bfd

fix: skip test for angular

0b74d00

fix: skip test for angular

b0fa322

fix: issues with wrong notification heading

04695d4

chore: update snapshots

09bbea3

nmerget linked an issue Apr 30, 2024 that may be closed by this pull request

tabs: role="tab"-attribute placement #2476

Open

nmerget added 10 commits April 30, 2024 10:16

chore: update snapshots

7c55780

fix: issue with vue showcase for popover

a4d4421

chore: add additional e2e tests for showcases

59e172b

Merge branch 'main' of github.com:db-ui/mono into test-a11y-showcases

11fa42a

# Conflicts: # package-lock.json # showcases/angular-showcase/src/app/components/navigation-item/navigation-item.component.html # showcases/react-showcase/src/components/navigation-item/index.tsx

chore: update from main

ad9936a

Merge branch 'main' of github.com:db-ui/mono into test-a11y-showcases

8e6d4fd

fix: a11y issue for navigation

46d09a4

fix: a11y issue for tabs

4434539

chore: update snapshots

164589f

chore: update e2e tests for drawer

610475f

mfranzke reviewed May 13, 2024

View reviewed changes

packages/components/src/components/tab-item/tab-item.lite.tsx Show resolved Hide resolved

mfranzke reviewed May 13, 2024

View reviewed changes

showcases/e2e/fixtures/hover.ts Outdated Show resolved Hide resolved

mfranzke reviewed May 13, 2024

View reviewed changes

packages/components/src/components/popover/popover.scss Outdated Show resolved Hide resolved

mfranzke reviewed May 13, 2024

View reviewed changes

packages/components/src/components/tooltip/tooltip.scss Outdated Show resolved Hide resolved

mfranzke reviewed May 13, 2024

View reviewed changes

packages/components/src/components/tabs/tabs.spec.tsx Outdated Show resolved Hide resolved

nmerget and others added 4 commits May 13, 2024 08:36

Update showcases/e2e/fixtures/hover.ts

fe2ff5d

Co-authored-by: Maximilian Franzke <787658+mfranzke@users.noreply.github.com>

Update packages/components/src/components/tooltip/tooltip.scss

ab3e7a0

Co-authored-by: Maximilian Franzke <787658+mfranzke@users.noreply.github.com>

Update packages/components/src/components/popover/popover.scss

d3280d2

Co-authored-by: Maximilian Franzke <787658+mfranzke@users.noreply.github.com>

Update packages/components/src/components/tabs/tabs.spec.tsx

6c7ce80

Co-authored-by: Maximilian Franzke <787658+mfranzke@users.noreply.github.com>

mfranzke reviewed May 13, 2024

View reviewed changes

packages/components/src/components/tab-item/tab-item.lite.tsx Show resolved Hide resolved

mfranzke reviewed May 13, 2024

View reviewed changes

showcases/e2e/home/showcase-home.spec.ts Outdated Show resolved Hide resolved

mfranzke reviewed May 13, 2024

View reviewed changes

showcases/e2e/home/showcase-home.spec.ts Outdated Show resolved Hide resolved

mfranzke added 2 commits May 13, 2024 08:54

Update showcase-tab-item.spec.ts

42959e0

Update showcase-tabs.spec.ts

b415400

mfranzke reviewed May 13, 2024

View reviewed changes

showcases/react-showcase/src/components/index.tsx Outdated Show resolved Hide resolved

mfranzke reviewed May 13, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

nmerget and others added 8 commits May 13, 2024 12:33

Update showcases/e2e/home/showcase-home.spec.ts

3ecd826

Co-authored-by: Maximilian Franzke <787658+mfranzke@users.noreply.github.com>

fix: issue from PR

eef5b6b

feat: add aria and data passing for angular

411fda3

fix: issue with vue header showcase test

381659d

test: disable mask to test screenshots´issues

bc152d0

fix: issues with angular

1fb71df

Merge branch 'main' of github.com:db-ui/mono into test-a11y-showcases

d13bd72

# Conflicts: # __snapshots__/section/showcase/mobile-chrome/regular/neutral/DBSection-should-match-screenshot.png

fix: issues with angular showcase

850da4f

mfranzke approved these changes May 14, 2024

View reviewed changes

nmerget merged commit bb03adc into main May 14, 2024
37 checks passed

nmerget deleted the test-a11y-showcases branch May 14, 2024 11:15

mfranzke mentioned this pull request May 21, 2024

prepare 0.2.0 release #2665

Closed

nmerget linked an issue May 24, 2024 that may be closed by this pull request

test(a11y): integrate axe tests for tab(s) components #2230

Closed

nmerget mentioned this pull request May 24, 2024

test(a11y): integrate axe tests for tab(s) components #2230

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add a11y tests to showcases #2581

test: add a11y tests to showcases #2581

nmerget commented Apr 25, 2024

github-actions bot commented Apr 25, 2024

test: add a11y tests to showcases #2581

test: add a11y tests to showcases #2581

Conversation

nmerget commented Apr 25, 2024

Proposed changes

Types of changes

Further comments

github-actions bot commented Apr 25, 2024