Add assertion error messages

[connorskees]

Fixes #270 (comment)

[coveralls]

Coverage increased (+0.08%) to 99.251% when pulling efca40f on ConnorSkees:master into c57abf2 on dbader:master.

[dbader]

Using assert this way was a bad idea (by me). These should all be of the form

if not condition:
   raise ScheduleError(...)

Where ScheduleError is

class ScheduleValueError(ValueError):
   pass

(or a wrapper around another appropriate Python internal error class)

[connorskees]

Is something like this what you were thinking?

[dbader]

Is something like this what you were thinking?

Yep :)

[connorskees]

Did you want the assertRaises to also be changed to pytest's version? Otherwise, I believe there is nothing else to do for this pr :^)

[dbader]

What happened here? Let's leave the pass in to make sure we communicate that this should be an empty class. (Same above on the various error classes, just a stylistic thing)

[dbader]

Thanks! The assertRaises is fine. This looks pretty much ready, but I had one more stylistic comment (pass).

I just hope people weren't catching AssertionError in the current versions when we roll this out (:

[dbader]

And please add yourself to the contributors file (if you want)

[dbader]

Let's keep the condition the same for the checks. I know they're equivalent but I like 0 <= hour <= 23 better :P

[connorskees]

I agree!! But I couldn't figure out how to make them equivalent using that without making it
if not (0 <= hour <= 23) and I thought it was harder to read.

Do you think it should just be if not (0 <= hour <= 23) ?

[dbader]

Do you think it should just be if not (0 <= hour <= 23) ?

Mmmh yeah I think that's still easier to read :)

[connorskees]

efca40f

:^)

[dbader]

Gave this another review and found some more stuff, can you comment on those?

[dbader]

LGTM! 🎉 Nice work @connorskees!

[dbader]

This is now live in https://pypi.org/project/schedule/0.6.0/