Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Task): Create a Task Component #2

Closed
KwanJunWen opened this issue Oct 3, 2020 · 5 comments · Fixed by #6
Closed

feat(Task): Create a Task Component #2

KwanJunWen opened this issue Oct 3, 2020 · 5 comments · Fixed by #6

Comments

@KwanJunWen
Copy link
Contributor

Sometimes we would want to write a check list in markdown. Having a TaskList component allows users to create task list using JSX.

Would you be willing to help with a PR?

[X] Yes, absolutely
[ ] Yes, with some guidance
[ ] Unfortunately no time :'-(

Describe the solution you'd like

The markdown element could be created with the following

<TaskList tasks={tasks}  />

Each task should have a boolean that indicates whether if the task is checked.

Additional context

Refer to this for additional context.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.99. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@dbartholomae
Copy link
Owner

Tasklist is something like this?

[X] Test tasks
[ ] Become immortal

If so: I don't think this is actually supported in most Markdown versions - e. g. Gists don't render these.

@dbartholomae
Copy link
Owner

Ah, it's

  • Test tasks
  • Become immortal

Sounds good! I would suggest the following JSX though:

<Task checked>Test tasks</Task>
<Task>Become immortal</Task>

@KwanJunWen KwanJunWen changed the title feat(TaskList): Create a TaskList Component feat(Task): Create a Task Component Oct 4, 2020
@KwanJunWen
Copy link
Contributor Author

Sorry to bother as this is probably off-topic. This is my first time participating hacktoberfest and I am wondering whether if all the PRs that I've contributed will count towards hacktoberfest or not. Based on the requirements, it states that the repository need to have the hacktoberfest topic to be considered an eligible repository.

@dbartholomae
Copy link
Owner

@KwanJunWen I've already added the topic, so each PR should be eliglible. If you log into your profile at https://hacktoberfest.digitalocean.com/ you should be able to see details around this. If there is any problems, please let me know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants