better error handling

dbarzin · Nov 1, 2023 · d5369aa · d5369aa
1 parent 212028c
commit d5369aa
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/app/Http/Controllers/ControlController.php b/app/Http/Controllers/ControlController.php
@@ -562,10 +562,10 @@ public function plan(int $id)
     {
         // does not exists in that way
         $control = Control::find($id);
-        if ($control === null) {
-            return;
-        }
-xxxxx
+
+        // Control not found
+        abort_if($control === null, Response::HTTP_NOT_FOUND, '404 Not Found');
+
         $years = [];
         $cur_year = Carbon::now()->year;
         for ($i = 0; $i <= 3; $i++) {