Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix - non utf-8 encoded txt file decode correctly #77

Merged
merged 2 commits into from Mar 22, 2016
Merged

fix - non utf-8 encoded txt file decode correctly #77

merged 2 commits into from Mar 22, 2016

Conversation

ghost
Copy link

@ghost ghost commented Mar 8, 2016

Extracted strings from non utf-8 encoded txt file are broken.

  1. detect encoding
  2. decode correctly

@dbashford
Copy link
Owner

Missing package.json updates. Do you have a file I can use that you may have used for testing purposes? I can throw together a test.

@ghost
Copy link
Author

ghost commented Mar 9, 2016

Added non utf8 text test case.
Euc-jp encoded file('これは非UTF8 テキストファイルです' ('this is a non utf8 text file'))
Modified package.json.

@dbashford dbashford added this to the 1.3.0 milestone Mar 22, 2016
dbashford added a commit that referenced this pull request Mar 22, 2016
fix - non utf-8 encoded txt file decode correctly
@dbashford dbashford merged commit 0741593 into dbashford:master Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants