Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mooring Bug Fixes #436

Merged
merged 14 commits into from
Oct 2, 2018
Merged

Mooring Bug Fixes #436

merged 14 commits into from
Oct 2, 2018

Conversation

xzzy
Copy link
Collaborator

@xzzy xzzy commented Sep 25, 2018

This change is Reviewable

@coveralls
Copy link

coveralls commented Sep 25, 2018

Pull Request Test Coverage Report for Build 570

  • 0 of 97 (0.0%) changed or added relevant lines in 9 files are covered.
  • 66 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.09%) to 39.15%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mooring/serialisers.py 0 1 0.0%
mooring/settings.py 0 1 0.0%
mooring/forms.py 0 2 0.0%
mooring/wsgi.py 0 2 0.0%
mooring/migrations/0041_booking_send_invoice.py 0 5 0.0%
mooring/models.py 0 9 0.0%
mooring/api.py 0 10 0.0%
mooring/emails.py 0 12 0.0%
mooring/utils.py 0 55 0.0%
Files with Coverage Reduction New Missed Lines %
mooring/utils.py 1 0.0%
mooring/pdf.py 1 0.0%
ledger/payments/bpay/crn.py 1 55.22%
mooring/forms.py 1 0.0%
parkstay/models.py 1 54.38%
mooring/emails.py 2 0.0%
mooring/api.py 2 0.0%
mooring/models.py 5 0.0%
wildlifelicensing/apps/applications/views/conditions.py 22 82.67%
wildlifelicensing/apps/applications/views/view.py 30 42.86%
Totals Coverage Status
Change from base Build 542: -0.09%
Covered Lines: 11462
Relevant Lines: 29277

💛 - Coveralls

@scottp-dpaw
Copy link


mooring/cache/1ee25b30047aaab38878947785a4d57a.djcache, line 0 at r2 (raw file):
please remove these files and exclude mooring/cache/* in .gitignore

Copy link

@scottp-dpaw scottp-dpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 6 files at r1, 31 of 33 files at r2.
Reviewable status: 35 of 37 files reviewed, 1 unresolved discussion (waiting on @xzzy)

Copy link

@scottp-dpaw scottp-dpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 33 files at r2, 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@scottp-dpaw scottp-dpaw merged commit de46368 into dbca-wa:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants