Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate regos error checked #453

Merged
merged 2 commits into from
Oct 9, 2018
Merged

Duplicate regos error checked #453

merged 2 commits into from
Oct 9, 2018

Conversation

FatemehMoghadam
Copy link
Contributor

@FatemehMoghadam FatemehMoghadam commented Oct 9, 2018 •
edited by dbca-asi
Loading

This change is Reviewable

@coveralls
Copy link

coveralls commented Oct 9, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 584

  • 3 of 5 (60.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.001%) to 39.137%
Changes Missing Coverage Covered Lines Changed/Added Lines %
parkstay/views.py 3 5 60.0%
Files with Coverage Reduction New Missed Lines %
mooring/pdf.py 1 0.0%
ledger/payments/bpay/crn.py 1 55.22%
parkstay/models.py 1 54.38%
mooring/models.py 3 0.0%
Totals Coverage Status
Change from base Build 582: 0.001%
Covered Lines: 11466
Relevant Lines: 29297
💛 - Coveralls

wilsonc86
wilsonc86 reviewed Oct 9, 2018
View reviewed changes
Copy link
Contributor

@wilsonc86 wilsonc86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, 4 of 4 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dbca-asi dbca-asi merged commit 953c242 into dbca-wa:master Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilsonc86 wilsonc86 wilsonc86 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FatemehMoghadam @coveralls @wilsonc86 @dbca-asi