Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hover over closure reason for site breakdown #463

Merged
merged 8 commits into from
Oct 29, 2018

Conversation

FatemehMoghadam
Copy link
Contributor

@FatemehMoghadam FatemehMoghadam commented Oct 23, 2018

This change is Reviewable

@coveralls
Copy link

coveralls commented Oct 23, 2018

Pull Request Test Coverage Report for Build 610

  • 11 of 27 (40.74%) changed or added relevant lines in 5 files are covered.
  • 8 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.01%) to 35.953%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ledger/payments/models.py 6 7 85.71%
parkstay/api.py 0 2 0.0%
ledger/payments/utils.py 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
parkstay/models.py 1 54.38%
mooring/pdf.py 1 0.0%
ledger/payments/bpay/crn.py 1 55.22%
ledger/payments/utils.py 2 13.29%
mooring/models.py 3 0.0%
Totals Coverage Status
Change from base Build 609: 0.01%
Covered Lines: 11478
Relevant Lines: 31925

💛 - Coveralls

Copy link
Contributor

@wilsonc86 wilsonc86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link

@scottp-dpaw scottp-dpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 15 of 15 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link

@scottp-dpaw scottp-dpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link

@scottp-dpaw scottp-dpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@scottp-dpaw scottp-dpaw merged commit 94f73ff into dbca-wa:master Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants