Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ledger: update checkout/views.py #464

Merged
merged 3 commits into from
Nov 7, 2018
Merged

ledger: update checkout/views.py #464

merged 3 commits into from
Nov 7, 2018

Conversation

wilsonc86
Copy link
Contributor

@wilsonc86 wilsonc86 commented Oct 25, 2018

fix up the "skip payment if free or if proxy applicant" functionality using local functions when get is called on PaymentDetailsView


This change is Reviewable

fix up the "skip payment if free or if proxy applicant" functionality using local functions when get is called on PaymentDetailsView
@coveralls
Copy link

coveralls commented Oct 25, 2018

Pull Request Test Coverage Report for Build 627

  • 7 of 8 (87.5%) changed or added relevant lines in 1 file are covered.
  • 294 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.02%) to 35.959%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ledger/checkout/session.py 7 8 87.5%
Files with Coverage Reduction New Missed Lines %
mooring/pdf.py 1 0.0%
ledger/payments/bpay/crn.py 1 55.22%
mooring/models.py 3 0.0%
ledger/payments/models.py 3 91.25%
ledger/checkout/utils.py 27 70.64%
parkstay/api.py 76 18.29%
ledger/payments/utils.py 82 13.01%
parkstay/models.py 101 54.38%
Totals Coverage Status
Change from base Build 606: 0.02%
Covered Lines: 11487
Relevant Lines: 31945

💛 - Coveralls

…ixin - check_payment_data_is_captured to fix loop
Copy link

@scottp-dpaw scottp-dpaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@scottp-dpaw scottp-dpaw merged commit 73698ae into dbca-wa:master Nov 7, 2018
@wilsonc86 wilsonc86 deleted the patch-1 branch November 7, 2018 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants