Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rottnest Bug Fixes #558

Merged
merged 10 commits into from
Mar 12, 2019
Merged

Rottnest Bug Fixes #558

merged 10 commits into from
Mar 12, 2019

Conversation

xzzy
Copy link
Collaborator

@xzzy xzzy commented Mar 12, 2019 •
edited by dbca-asi
Loading

This change is Reviewable

@coveralls
Copy link

coveralls commented Mar 12, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 704

  • 20 of 121 (16.53%) changed or added relevant lines in 8 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 37.013%
Changes Missing Coverage Covered Lines Changed/Added Lines %
mooring/context_processors.py 1 2 50.0%
mooring/management/commands/set_global_settings.py 0 1 0.0%
mooring/utils.py 0 1 0.0%
mooring/api.py 1 7 14.29%
mooring/emails.py 4 44 9.09%
mooring/views.py 6 58 10.34%
Files with Coverage Reduction New Missed Lines %
mooring/api.py 1 25.28%
mooring/views.py 5 23.34%
Totals Coverage Status
Change from base Build 699: -0.05%
Covered Lines: 17171
Relevant Lines: 46392
💛 - Coveralls

wilsonc86
wilsonc86 reviewed Mar 12, 2019
View reviewed changes
Copy link
Contributor

@wilsonc86 wilsonc86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 26 of 27 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dbca-asi dbca-asi merged commit f7c3025 into dbca-wa:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilsonc86 wilsonc86 wilsonc86 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xzzy @coveralls @wilsonc86 @dbca-asi