Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade coverage to 5.x #1158

Merged
merged 1 commit into from
Mar 18, 2020
Merged

upgrade coverage to 5.x #1158

merged 1 commit into from
Mar 18, 2020

Conversation

laixintao
Copy link
Member

@laixintao laixintao commented Mar 18, 2020

Description

This fixes the coverage issue from #1157 , it tunes out that the version of coverage.py we are using is broken on Python3.8, which produces some phantom lines. see nedbat/coveragepy#714 (which is actually interesting).

So simply upgrade coverage.py solves the problen.

Checklist

  • I've added this contribution to the changelog.rst.
  • I've added my name to the AUTHORS file (or it's already there).
  • I installed pre-commit hooks (pip install pre-commit && pre-commit install), and ran black on my code.
  • Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)

@laixintao
Copy link
Member Author

The line data from @pasenor 's script draws my attention( #1157 (comment) ), I don't the difference is normal, but the script is correct and I even checked the lines manually.

I figured it out by running coverage locally, this is html report from Python3.6 pgcli/main.py:

image

And this from Python3.8:

image

Then google lead me to nedbat/coveragepy#714

@j-bennet
Copy link
Contributor

@laixintao Good catch!

@j-bennet j-bennet merged commit d444db4 into master Mar 18, 2020
@j-bennet j-bennet deleted the laixintao/coverage branch March 18, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants