Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Echo notifications #1385

Merged
merged 8 commits into from
Mar 23, 2024
Merged

Echo notifications #1385

merged 8 commits into from
Mar 23, 2024

Conversation

amacfie
Copy link
Contributor

@amacfie amacfie commented Nov 23, 2022

Description

An implementation of #1359. If you run listen channelname and the channel receives a notification, the next time you run a statement, the notification will be shown (similar to psql).

Checklist

  • I've added this contribution to the changelog.rst.
  • I've added my name to the AUTHORS file (or it's already there).
  • I installed pre-commit hooks (pip install pre-commit && pre-commit install), and ran black on my code.
  • Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)

@amacfie amacfie marked this pull request as ready for review March 18, 2024 19:04
@amacfie
Copy link
Contributor Author

amacfie commented Mar 18, 2024

@j-bennet ready for review

Copy link
Contributor

@j-bennet j-bennet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. Thank you for the PR!

@j-bennet
Copy link
Contributor

@amacfie Please address the test failures, and then it'll be good to merge.

@amacfie
Copy link
Contributor Author

amacfie commented Mar 20, 2024

Whoops, should be good now

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.07%. Comparing base (9f114c4) to head (a494294).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1385      +/-   ##
==========================================
+ Coverage   80.04%   80.07%   +0.03%     
==========================================
  Files          25       25              
  Lines        3067     3072       +5     
==========================================
+ Hits         2455     2460       +5     
  Misses        612      612              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j-bennet j-bennet merged commit a7a70fd into dbcli:main Mar 23, 2024
7 checks passed
@j-bennet
Copy link
Contributor

Well done! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants