Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named query positional parameters aggregation #108

Merged
merged 2 commits into from
May 9, 2021
Merged

Named query positional parameters aggregation #108

merged 2 commits into from
May 9, 2021

Conversation

chagui
Copy link
Member

@chagui chagui commented May 8, 2021

Description

This pull-request propose an implementation for #106. The proposal adds 2 new placeholders $* and $@, respectively raw aggregation and string aggregation. The difference being that the later will quote the argument values, removing the need to quote the argument (e.g. 'foo' instead of \'foo\').
I took the addition to add tests for subst_favorite_query_args covering both current and new placeholders.

Checklist

  • I've added this contribution to the changelog.rst.
  • I installed pre-commit hooks (pip install pre-commit && pre-commit install), and ran black on my code.
  • Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@20dc99f). Click here to learn what that means.
The diff coverage is 65.51%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #108   +/-   ##
=========================================
  Coverage          ?   29.08%           
=========================================
  Files             ?        6           
  Lines             ?     2486           
  Branches          ?        0           
=========================================
  Hits              ?      723           
  Misses            ?     1763           
  Partials          ?        0           
Impacted Files Coverage Δ
pgspecial/help/commands.py 0.20% <ø> (ø)
pgspecial/main.py 38.18% <52.17%> (ø)
pgspecial/iocommands.py 41.86% <65.15%> (ø)
pgspecial/dbcommands.py 33.60% <66.73%> (ø)
pgspecial/namedqueries.py 92.00% <75.00%> (ø)
pgspecial/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20dc99f...fbea9d9. Read the comment docs.

@amjith
Copy link
Member

amjith commented May 9, 2021

Looks good. Thanks for adding tests. 👍

@amjith amjith merged commit f04a54c into dbcli:master May 9, 2021
@chagui chagui changed the title Named query positionial parameters aggregation Named query positional parameters aggregation May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants