Fix inherits #48
Fix inherits #48
Conversation
Emit only the table name, not the whole record tuple, and add the trailing comma only when needed.
This make it easier to pass additional arguments to pytest, for example to show the complete diff in case of errors you would execute `tox -- -vv`.
|
Uhm, should I fix those style issues too? |
|
@lelit Looks like pep8radius is not happy with these changes. |
|
Yes, I saw that, but strictly speaking those errors are not caused by my changes 😈 so I wonder if I should take care of them in the context of this PR or not. |
|
Yes, please do - it only takes running |
|
Ok, will do that tomorrow. Thank you. |
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
=========================================
Coverage ? 52.46%
=========================================
Files ? 6
Lines ? 911
Branches ? 0
=========================================
Hits ? 478
Misses ? 433
Partials ? 0
Continue to review full report at Codecov.
|
|
Well, I found some spare minutes... :) |
tests/test_specials.py
Outdated
| results = executor('\d tbl1') | ||
| title = None | ||
| rows = [['id1', 'integer', ' not null'], | ||
| ['txt1', 'text', ' not null'], | ||
| ] | ||
| headers = ['Column', 'Type', 'Modifiers'] | ||
| status = 'Indexes:\n "id_text" PRIMARY KEY, btree (id1, txt1)\n' | ||
| status = ('Indexes:\n "id_text" PRIMARY KEY, btree (id1, txt1)\n' | ||
| 'Number of child tables: 2 (Use \\d+ to listthem.)\n') |
There was a problem hiding this comment.
"to listthem" - is that a typo?
|
Looks great! Merging. |
|
Great, thank you! |
Description
Currently when a table has children, the
\dcommand outputs something likethat is
With this PR it would emit something like
matching the output of the corresponding command in
psql.Checklist
changelog.rst.