Implementing random moves UP TO 20% of the time #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Bumping version Simplify playerHasWon logic Remove optimization for checking win states Splits out utility functions and tests into individual files. Adds a couple utility functions and makes the API more consistent between functions. Fix specs Adds utility functions available through BotUtils
dbe
approved these changes
Oct 10, 2017
| const buildConsecutive = checkForWinMove(boardModel, player, gameState, winLength - 1); // try to get 3 in a row | ||
| const whatevs = getMove(boardModel, gameState); // place a token somewhere near the center | ||
|
|
||
| return win || survive || blockProgress || buildConsecutive || whatevs; |
There was a problem hiding this comment.
Just FYI here, if you did those variables inline instead of precomputing them, then it would short circuit on the first true one and save time in the average case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Adds a new mickeyBot which makes a random move up to 20% of the time.
Where should the reviewer start?
mickeyBot.js
How should this be manually tested?
Any background context you want to provide?
No.
New dependencies? What are they used for?
No.
What are the relevant tickets?
No.
What gif best describes how this PR makes you feel?